======================================================
WARNING: possible circular locking dependency detected
6.2.0-rc6-next-20230203 #1 Not tainted
------------------------------------------------------
syz-executor.0/13658 is trying to acquire lock:
ffff88800ffea170 (&journal->j_barrier){+.+.}-{3:3}, at: jbd2_journal_lock_updates+0x162/0x310
but task is already holding lock:
ffff88800ffe8b90 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_change_inode_journal_flag+0x17f/0x550
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #3 (&sbi->s_writepages_rwsem){++++}-{0:0}:
ext4_writepages+0x1a9/0x5e0
do_writepages+0x1ad/0x650
filemap_fdatawrite_wbc+0x14b/0x1b0
__filemap_fdatawrite_range+0xba/0x100
filemap_write_and_wait_range+0xa5/0x130
__iomap_dio_rw+0x5ea/0x1ce0
iomap_dio_rw+0x40/0xa0
ext4_file_read_iter+0x2f4/0x4a0
generic_file_splice_read+0x18b/0x4d0
do_splice_to+0x1bc/0x240
splice_direct_to_actor+0x2b0/0x8c0
do_splice_direct+0x1bc/0x290
do_sendfile+0xb1d/0x12b0
__x64_sys_sendfile64+0x1d5/0x210
do_syscall_64+0x3f/0x90
entry_SYSCALL_64_after_hwframe+0x72/0xdc
-> #2 (&sb->s_type->i_mutex_key#6){++++}-{3:3}:
down_read+0x3d/0x50
ext4_bmap+0x52/0x470
bmap+0xb0/0x130
jbd2_journal_bmap+0xac/0x1d0
jbd2_journal_flush+0x87f/0xc90
__ext4_ioctl+0x9fd/0x4330
__x64_sys_ioctl+0x19e/0x210
do_syscall_64+0x3f/0x90
entry_SYSCALL_64_after_hwframe+0x72/0xdc
-> #1 (&journal->j_checkpoint_mutex){+.+.}-{3:3}:
mutex_lock_io_nested+0x149/0x1300
jbd2_journal_flush+0x19e/0xc90
__ext4_ioctl+0x9fd/0x4330
__x64_sys_ioctl+0x19e/0x210
do_syscall_64+0x3f/0x90
entry_SYSCALL_64_after_hwframe+0x72/0xdc
-> #0 (&journal->j_barrier){+.+.}-{3:3}:
__lock_acquire+0x2da7/0x63b0
lock_acquire.part.0+0xec/0x320
__mutex_lock+0x133/0x14a0
jbd2_journal_lock_updates+0x162/0x310
ext4_change_inode_journal_flag+0x187/0x550
ext4_fileattr_set+0x14fa/0x19f0
vfs_fileattr_set+0x7a2/0xbd0
do_vfs_ioctl+0xfc1/0x1690
__x64_sys_ioctl+0x110/0x210
do_syscall_64+0x3f/0x90
entry_SYSCALL_64_after_hwframe+0x72/0xdc
other info that might help us debug this:
Chain exists of:
&journal->j_barrier --> &sb->s_type->i_mutex_key#6 --> &sbi->s_writepages_rwsem
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&sbi->s_writepages_rwsem);
lock(&sb->s_type->i_mutex_key#6);
lock(&sbi->s_writepages_rwsem);
lock(&journal->j_barrier);
*** DEADLOCK ***
4 locks held by syz-executor.0/13658:
#0: ffff88800fab6438 (sb_writers#3){.+.+}-{0:0}, at: do_vfs_ioctl+0xf86/0x1690
#1: ffff888045a48df0 (&sb->s_type->i_mutex_key#6){++++}-{3:3}, at: vfs_fileattr_set+0x14c/0xbd0
#2: ffff888045a48f90 (mapping.invalidate_lock){++++}-{3:3}, at: ext4_change_inode_journal_flag+0x126/0x550
#3: ffff88800ffe8b90 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_change_inode_journal_flag+0x17f/0x550
stack backtrace:
CPU: 1 PID: 13658 Comm: syz-executor.0 Not tainted 6.2.0-rc6-next-20230203 #1
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014
Call Trace:
<TASK>
dump_stack_lvl+0x91/0xf0
check_noncircular+0x263/0x2e0
__lock_acquire+0x2da7/0x63b0
lock_acquire.part.0+0xec/0x320
__mutex_lock+0x133/0x14a0
jbd2_journal_lock_updates+0x162/0x310
ext4_change_inode_journal_flag+0x187/0x550
ext4_fileattr_set+0x14fa/0x19f0
vfs_fileattr_set+0x7a2/0xbd0
do_vfs_ioctl+0xfc1/0x1690
__x64_sys_ioctl+0x110/0x210
do_syscall_64+0x3f/0x90
entry_SYSCALL_64_after_hwframe+0x72/0xdc
RIP: 0033:0x7fef797c9b19
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fef76d3f188 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007fef798dcf60 RCX: 00007fef797c9b19
RDX: 0000000020000040 RSI: 0000000040086602 RDI: 0000000000000003
RBP: 00007fef79823f6d R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007fffaf56e24f R14: 00007fef76d3f300 R15: 0000000000022000
</TASK>
FAULT_INJECTION: forcing a failure.
name failslab, interval 1, probability 0, space 0, times 0
CPU: 1 PID: 13648 Comm: syz-executor.5 Not tainted 6.2.0-rc6-next-20230203 #1
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014
Call Trace:
<TASK>
dump_stack_lvl+0xc1/0xf0
should_fail_ex+0x4b4/0x5b0
should_failslab+0x9/0x20
kmem_cache_alloc+0x5a/0x320
ext4_mb_new_blocks+0x1901/0x4ad0
ext4_ext_map_blocks+0x2004/0x5dd0
ext4_map_blocks+0x776/0x19e0
ext4_alloc_file_blocks.isra.0+0x2df/0xbd0
ext4_fallocate+0x1fc5/0x3f50
vfs_fallocate+0x48d/0xe30
__x64_sys_fallocate+0xd3/0x140
do_syscall_64+0x3f/0x90
entry_SYSCALL_64_after_hwframe+0x72/0xdc
RIP: 0033:0x7f312870db19
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f3125c83188 EFLAGS: 00000246 ORIG_RAX: 000000000000011d
RAX: ffffffffffffffda RBX: 00007f3128820f60 RCX: 00007f312870db19
RDX: 0000000000000000 RSI: 0000000000000010 RDI: 0000000000000006
RBP: 00007f3125c831d0 R08: 0000000000000000 R09: 0000000000000000
R10: 00000000087ffffc R11: 0000000000000246 R12: 0000000000000002
R13: 00007ffd0d9bceef R14: 00007f3125c83300 R15: 0000000000022000
</TASK>
loop3: detected capacity change from 0 to 272