RBP: 00007fa96f4fb1d0 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000001
R13: 00007ffe2e2d561f R14: 00007fa96f4fb300 R15: 0000000000022000
 </TASK>
======================================================
WARNING: possible circular locking dependency detected
6.1.0-rc3-next-20221104 #1 Not tainted
------------------------------------------------------
syz-executor.7/17594 is trying to acquire lock:
ffff88800fd44170 (&journal->j_barrier){+.+.}-{3:3}, at: jbd2_journal_lock_updates+0x15e/0x310

but task is already holding lock:
ffff88800fd42b90 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_change_inode_journal_flag+0x177/0x530

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&sbi->s_writepages_rwsem){++++}-{0:0}:
       ext4_writepages+0x1d2/0x3690
       do_writepages+0x1b0/0x6a0
       filemap_fdatawrite_wbc+0x147/0x1b0
       __filemap_fdatawrite_range+0xb6/0x100
       filemap_write_and_wait_range+0x89/0x110
       __iomap_dio_rw+0x5ed/0x1bd0
       iomap_dio_rw+0x3c/0xa0
       ext4_file_write_iter+0xb59/0x1900
       do_iter_readv_writev+0x211/0x3c0
       do_iter_write+0x18b/0x700
       vfs_iter_write+0x70/0xa0
       iter_file_splice_write+0x73a/0xca0
       direct_splice_actor+0x10f/0x170
       splice_direct_to_actor+0x336/0x8c0
       do_splice_direct+0x1b8/0x290
       do_sendfile+0xb1d/0x1280
       __x64_sys_sendfile64+0x1d1/0x210
       do_syscall_64+0x3b/0x90
       entry_SYSCALL_64_after_hwframe+0x72/0xdc

-> #2 (&sb->s_type->i_mutex_key#6){++++}-{3:3}:
       down_read+0x98/0x450
       ext4_bmap+0x4e/0x470
       bmap+0xac/0x120
       jbd2_journal_bmap+0xa8/0x180
       jbd2_journal_flush+0x853/0xc00
       __ext4_ioctl+0x9c1/0x4140
       __x64_sys_ioctl+0x19a/0x210
       do_syscall_64+0x3b/0x90
       entry_SYSCALL_64_after_hwframe+0x72/0xdc

-> #1 (&journal->j_checkpoint_mutex){+.+.}-{3:3}:
       mutex_lock_io_nested+0x148/0x1310
       jbd2_journal_flush+0x19a/0xc00
       __ext4_ioctl+0x9c1/0x4140
       __x64_sys_ioctl+0x19a/0x210
       do_syscall_64+0x3b/0x90
       entry_SYSCALL_64_after_hwframe+0x72/0xdc

-> #0 (&journal->j_barrier){+.+.}-{3:3}:
       __lock_acquire+0x2a02/0x5e70
       lock_acquire+0x1a2/0x530
       __mutex_lock+0x136/0x14d0
       jbd2_journal_lock_updates+0x15e/0x310
       ext4_change_inode_journal_flag+0x17f/0x530
       ext4_fileattr_set+0x1427/0x18c0
       vfs_fileattr_set+0x77c/0xb80
       do_vfs_ioctl+0xfa6/0x15d0
       __x64_sys_ioctl+0x10c/0x210
       do_syscall_64+0x3b/0x90
       entry_SYSCALL_64_after_hwframe+0x72/0xdc

other info that might help us debug this:

Chain exists of:
  &journal->j_barrier --> &sb->s_type->i_mutex_key#6 --> &sbi->s_writepages_rwsem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&sbi->s_writepages_rwsem);
                               lock(&sb->s_type->i_mutex_key#6);
                               lock(&sbi->s_writepages_rwsem);
  lock(&journal->j_barrier);

 *** DEADLOCK ***

4 locks held by syz-executor.7/17594:
 #0: ffff88800fd40438 (sb_writers#3){.+.+}-{0:0}, at: do_vfs_ioctl+0xf6b/0x15d0
 #1: ffff888019598df0 (&type->i_mutex_dir_key#3){++++}-{3:3}, at: vfs_fileattr_set+0x148/0xb80
 #2: ffff888019598f90 (mapping.invalidate_lock){++++}-{3:3}, at: ext4_change_inode_journal_flag+0x11e/0x530
 #3: ffff88800fd42b90 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_change_inode_journal_flag+0x177/0x530

stack backtrace:
CPU: 0 PID: 17594 Comm: syz-executor.7 Not tainted 6.1.0-rc3-next-20221104 #1
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014
Call Trace:
 <TASK>
 dump_stack_lvl+0x8b/0xb3
 check_noncircular+0x263/0x2e0
 __lock_acquire+0x2a02/0x5e70
 lock_acquire+0x1a2/0x530
 __mutex_lock+0x136/0x14d0
 jbd2_journal_lock_updates+0x15e/0x310
 ext4_change_inode_journal_flag+0x17f/0x530
 ext4_fileattr_set+0x1427/0x18c0
 vfs_fileattr_set+0x77c/0xb80
 do_vfs_ioctl+0xfa6/0x15d0
 __x64_sys_ioctl+0x10c/0x210
 do_syscall_64+0x3b/0x90
 entry_SYSCALL_64_after_hwframe+0x72/0xdc
RIP: 0033:0x7ff707f8ab19
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ff705500188 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007ff70809df60 RCX: 00007ff707f8ab19
RDX: 0000000020000040 RSI: 0000000040086602 RDI: 0000000000000003
RBP: 00007ff707fe4f6d R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ffd64634c1f R14: 00007ff705500300 R15: 0000000000022000
 </TASK>