WARNING: stack going in the wrong direction? at perf_trace_lock+0xc1/0x480 ====================================================== WARNING: possible circular locking dependency detected 6.2.0-rc8-next-20230217 #1 Not tainted ------------------------------------------------------ syz-executor.1/10973 is trying to acquire lock: ffff8880100163f8 (&journal->j_checkpoint_mutex){+.+.}-{3:3}, at: __jbd2_log_wait_for_space+0x238/0x4b0 but task is already holding lock: ffff888010014b90 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: do_writepages+0x1ad/0x650 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&sbi->s_writepages_rwsem){++++}-{0:0}: percpu_down_write+0x51/0x350 ext4_ind_migrate+0x23b/0x840 ext4_fileattr_set+0x1521/0x19f0 vfs_fileattr_set+0x7a2/0xbd0 do_vfs_ioctl+0xfc1/0x1690 __x64_sys_ioctl+0x110/0x210 do_syscall_64+0x3f/0x90 entry_SYSCALL_64_after_hwframe+0x72/0xdc -> #1 (&sb->s_type->i_mutex_key#6){++++}-{3:3}: down_read+0x3d/0x50 ext4_bmap+0x52/0x470 bmap+0xb0/0x130 jbd2_journal_bmap+0xac/0x1d0 jbd2_journal_flush+0x87f/0xc90 __ext4_ioctl+0x9fd/0x4330 __x64_sys_ioctl+0x19e/0x210 do_syscall_64+0x3f/0x90 entry_SYSCALL_64_after_hwframe+0x72/0xdc -> #0 (&journal->j_checkpoint_mutex){+.+.}-{3:3}: __lock_acquire+0x2da7/0x63b0 lock_acquire.part.0+0xec/0x320 mutex_lock_io_nested+0x149/0x1300 __jbd2_log_wait_for_space+0x238/0x4b0 add_transaction_credits+0xa42/0xb80 start_this_handle+0x3a6/0x14d0 jbd2__journal_start+0x394/0x6b0 __ext4_journal_start_sb+0x4c2/0x6f0 ext4_do_writepages+0xbb5/0x33f0 ext4_writepages+0x274/0x5e0 do_writepages+0x1ad/0x650 filemap_fdatawrite_wbc+0x14b/0x1b0 __filemap_fdatawrite_range+0xba/0x100 file_write_and_wait_range+0xd2/0x140 ext4_sync_file+0x221/0x1010 vfs_fsync_range+0x141/0x230 ext4_buffered_write_iter+0x37d/0x460 ext4_file_write_iter+0x3ff/0x1930 do_iter_readv_writev+0x211/0x3c0 do_iter_write+0x18b/0x700 vfs_iter_write+0x74/0xb0 iter_file_splice_write+0x73f/0xcb0 direct_splice_actor+0x113/0x180 splice_direct_to_actor+0x33a/0x8c0 do_splice_direct+0x1bc/0x290 do_sendfile+0xb1d/0x12b0 __x64_sys_sendfile64+0x1d5/0x210 do_syscall_64+0x3f/0x90 entry_SYSCALL_64_after_hwframe+0x72/0xdc other info that might help us debug this: Chain exists of: &journal->j_checkpoint_mutex --> &sb->s_type->i_mutex_key#6 --> &sbi->s_writepages_rwsem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- rlock(&sbi->s_writepages_rwsem); lock(&sb->s_type->i_mutex_key#6); lock(&sbi->s_writepages_rwsem); lock(&journal->j_checkpoint_mutex); *** DEADLOCK *** 2 locks held by syz-executor.1/10973: #0: ffff888010012438 (sb_writers#3){.+.+}-{0:0}, at: __x64_sys_sendfile64+0x1d5/0x210 #1: ffff888010014b90 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: do_writepages+0x1ad/0x650 stack backtrace: CPU: 1 PID: 10973 Comm: syz-executor.1 Not tainted 6.2.0-rc8-next-20230217 #1 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014 Call Trace: dump_stack_lvl+0x91/0xf0 check_noncircular+0x263/0x2e0 __lock_acquire+0x2da7/0x63b0 lock_acquire.part.0+0xec/0x320 mutex_lock_io_nested+0x149/0x1300 __jbd2_log_wait_for_space+0x238/0x4b0 add_transaction_credits+0xa42/0xb80 start_this_handle+0x3a6/0x14d0 jbd2__journal_start+0x394/0x6b0 __ext4_journal_start_sb+0x4c2/0x6f0 ext4_do_writepages+0xbb5/0x33f0 ext4_writepages+0x274/0x5e0 do_writepages+0x1ad/0x650 filemap_fdatawrite_wbc+0x14b/0x1b0 __filemap_fdatawrite_range+0xba/0x100 file_write_and_wait_range+0xd2/0x140 ext4_sync_file+0x221/0x1010 vfs_fsync_range+0x141/0x230 ext4_buffered_write_iter+0x37d/0x460 ext4_file_write_iter+0x3ff/0x1930 do_iter_readv_writev+0x211/0x3c0 do_iter_write+0x18b/0x700 vfs_iter_write+0x74/0xb0 iter_file_splice_write+0x73f/0xcb0 direct_splice_actor+0x113/0x180 splice_direct_to_actor+0x33a/0x8c0 do_splice_direct+0x1bc/0x290 do_sendfile+0xb1d/0x12b0 __x64_sys_sendfile64+0x1d5/0x210 do_syscall_64+0x3f/0x90 entry_SYSCALL_64_after_hwframe+0x72/0xdc RIP: 0033:0x7f4b84c84b19 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f4b821fa188 EFLAGS: 00000246 ORIG_RAX: 0000000000000028 RAX: ffffffffffffffda RBX: 00007f4b84d97f60 RCX: 00007f4b84c84b19 RDX: 0000000000000000 RSI: 0000000000000003 RDI: 0000000000000004 RBP: 00007f4b84cdef6d R08: 0000000000000000 R09: 0000000000000000 R10: 00000000fffffdef R11: 0000000000000246 R12: 0000000000000000 R13: 00007ffc2c2e73df R14: 00007f4b821fa300 R15: 0000000000022000 syz-executor.1 (10973) used greatest stack depth: 23128 bytes left