warning: checkpointing journal with EXT4_IOC_CHECKPOINT_FLAG_ZEROOUT can be slow
======================================================
WARNING: possible circular locking dependency detected
6.3.0-rc1-next-20230308 #1 Not tainted
------------------------------------------------------
syz-executor.1/6680 is trying to acquire lock:
ffff88800c160400 (&sb->s_type->i_mutex_key#6){++++}-{3:3}, at: ext4_bmap+0x52/0x470
but task is already holding lock:
ffff8880100103f8 (&journal->j_checkpoint_mutex){+.+.}-{3:3}, at: jbd2_journal_flush+0x483/0xc90
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #3 (&journal->j_checkpoint_mutex){+.+.}-{3:3}:
mutex_lock_io_nested+0x149/0x1300
jbd2_journal_flush+0x19e/0xc90
__ext4_ioctl+0x9fd/0x4330
__x64_sys_ioctl+0x19e/0x210
do_syscall_64+0x3f/0x90
entry_SYSCALL_64_after_hwframe+0x72/0xdc
-> #2 (&journal->j_barrier){+.+.}-{3:3}:
__mutex_lock+0x133/0x14a0
jbd2_journal_lock_updates+0x162/0x310
ext4_change_inode_journal_flag+0x187/0x550
ext4_fileattr_set+0x14fa/0x19f0
vfs_fileattr_set+0x7a2/0xbd0
do_vfs_ioctl+0xfc1/0x1690
__x64_sys_ioctl+0x110/0x210
do_syscall_64+0x3f/0x90
entry_SYSCALL_64_after_hwframe+0x72/0xdc
-> #1 (&sbi->s_writepages_rwsem){++++}-{0:0}:
percpu_down_write+0x51/0x330
ext4_ind_migrate+0x23b/0x840
ext4_fileattr_set+0x1521/0x19f0
vfs_fileattr_set+0x7a2/0xbd0
do_vfs_ioctl+0xfc1/0x1690
__x64_sys_ioctl+0x110/0x210
do_syscall_64+0x3f/0x90
entry_SYSCALL_64_after_hwframe+0x72/0xdc
-> #0 (&sb->s_type->i_mutex_key#6){++++}-{3:3}:
__lock_acquire+0x2d56/0x6380
lock_acquire.part.0+0xea/0x320
down_read+0x3d/0x50
ext4_bmap+0x52/0x470
bmap+0xb0/0x130
jbd2_journal_bmap+0xac/0x1d0
jbd2_journal_flush+0x87f/0xc90
__ext4_ioctl+0x9fd/0x4330
__x64_sys_ioctl+0x19e/0x210
do_syscall_64+0x3f/0x90
entry_SYSCALL_64_after_hwframe+0x72/0xdc
other info that might help us debug this:
Chain exists of:
&sb->s_type->i_mutex_key#6 --> &journal->j_barrier --> &journal->j_checkpoint_mutex
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&journal->j_checkpoint_mutex);
lock(&journal->j_barrier);
lock(&journal->j_checkpoint_mutex);
lock(&sb->s_type->i_mutex_key#6);
*** DEADLOCK ***
2 locks held by syz-executor.1/6680:
#0: ffff888010010170 (&journal->j_barrier){+.+.}-{3:3}, at: jbd2_journal_lock_updates+0x162/0x310
#1: ffff8880100103f8 (&journal->j_checkpoint_mutex){+.+.}-{3:3}, at: jbd2_journal_flush+0x483/0xc90
stack backtrace:
CPU: 0 PID: 6680 Comm: syz-executor.1 Not tainted 6.3.0-rc1-next-20230308 #1
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014
Call Trace:
dump_stack_lvl+0x91/0xf0
check_noncircular+0x263/0x2e0
__lock_acquire+0x2d56/0x6380
lock_acquire.part.0+0xea/0x320
down_read+0x3d/0x50
ext4_bmap+0x52/0x470
bmap+0xb0/0x130
jbd2_journal_bmap+0xac/0x1d0
jbd2_journal_flush+0x87f/0xc90
__ext4_ioctl+0x9fd/0x4330
__x64_sys_ioctl+0x19e/0x210
do_syscall_64+0x3f/0x90
entry_SYSCALL_64_after_hwframe+0x72/0xdc
RIP: 0033:0x7f54e2a47b19
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f54dffbd188 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007f54e2b5af60 RCX: 00007f54e2a47b19
RDX: 0000000020000000 RSI: 000000004004662b RDI: 0000000000000006
RBP: 00007f54e2aa1f6d R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ffdefb8efaf R14: 00007f54dffbd300 R15: 0000000000022000
FAULT_INJECTION: forcing a failure.
name fail_usercopy, interval 1, probability 0, space 0, times 1
CPU: 1 PID: 6695 Comm: syz-executor.6 Not tainted 6.3.0-rc1-next-20230308 #1
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014
Call Trace:
dump_stack_lvl+0xc1/0xf0
should_fail_ex+0x4b4/0x5b0
_copy_from_user+0x2e/0x180
move_addr_to_kernel.part.0+0x31/0x110
__sys_connect+0xde/0x1a0
__x64_sys_connect+0x73/0xb0
do_syscall_64+0x3f/0x90
entry_SYSCALL_64_after_hwframe+0x72/0xdc
RIP: 0033:0x7f6162193b19
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f615f709188 EFLAGS: 00000246 ORIG_RAX: 000000000000002a
RAX: ffffffffffffffda RBX: 00007f61622a6f60 RCX: 00007f6162193b19
RDX: 0000000000000014 RSI: 00000000200005c0 RDI: 0000000000000005
RBP: 00007f615f7091d0 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000001
R13: 00007ffe3429256f R14: 00007f615f709300 R15: 0000000000022000