======================================================
WARNING: possible circular locking dependency detected
6.1.0-rc4-next-20221109 #1 Not tainted
------------------------------------------------------
syz-executor.1/11104 is trying to acquire lock:
ffff88800b168400 (&sb->s_type->i_mutex_key#6){++++}-{3:3}, at: ext4_bmap+0x52/0x470

but task is already holding lock:
ffff88800fc643f8 (&journal->j_checkpoint_mutex){+.+.}-{3:3}, at: jbd2_journal_flush+0x48f/0xc10

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&journal->j_checkpoint_mutex){+.+.}-{3:3}:
       mutex_lock_io_nested+0x14c/0x1330
       jbd2_journal_flush+0x19e/0xc10
       ext4_ioctl_group_add+0x2b3/0x580
       __ext4_ioctl+0x697/0x4140
       __x64_sys_ioctl+0x19e/0x210
       do_syscall_64+0x3f/0x90
       entry_SYSCALL_64_after_hwframe+0x72/0xdc

-> #2 (&journal->j_barrier){+.+.}-{3:3}:
       __mutex_lock+0x136/0x14e0
       jbd2_journal_lock_updates+0x162/0x310
       ext4_change_inode_journal_flag+0x183/0x540
       ext4_fileattr_set+0x142b/0x18c0
       vfs_fileattr_set+0x780/0xb90
       do_vfs_ioctl+0xfa6/0x15d0
       __x64_sys_ioctl+0x110/0x210
       do_syscall_64+0x3f/0x90
       entry_SYSCALL_64_after_hwframe+0x72/0xdc

-> #1 (&sbi->s_writepages_rwsem){++++}-{0:0}:
       percpu_down_write+0x51/0x350
       ext4_ind_migrate+0x23b/0x830
       ext4_fileattr_set+0x1452/0x18c0
       vfs_fileattr_set+0x780/0xb90
       do_vfs_ioctl+0xfa6/0x15d0
       __x64_sys_ioctl+0x110/0x210
       do_syscall_64+0x3f/0x90
       entry_SYSCALL_64_after_hwframe+0x72/0xdc

-> #0 (&sb->s_type->i_mutex_key#6){++++}-{3:3}:
       __lock_acquire+0x2a02/0x5e70
       lock_acquire+0x1a6/0x530
       down_read+0x9c/0x450
       ext4_bmap+0x52/0x470
       bmap+0xb0/0x130
       jbd2_journal_bmap+0xac/0x190
       jbd2_journal_flush+0x857/0xc10
       __ext4_ioctl+0x9c1/0x4140
       __x64_sys_ioctl+0x19e/0x210
       do_syscall_64+0x3f/0x90
       entry_SYSCALL_64_after_hwframe+0x72/0xdc

other info that might help us debug this:

Chain exists of:
  &sb->s_type->i_mutex_key#6 --> &journal->j_barrier --> &journal->j_checkpoint_mutex

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&journal->j_checkpoint_mutex);
                               lock(&journal->j_barrier);
                               lock(&journal->j_checkpoint_mutex);
  lock(&sb->s_type->i_mutex_key#6);

 *** DEADLOCK ***

2 locks held by syz-executor.1/11104:
 #0: ffff88800fc64170 (&journal->j_barrier){+.+.}-{3:3}, at: jbd2_journal_lock_updates+0x162/0x310
 #1: ffff88800fc643f8 (&journal->j_checkpoint_mutex){+.+.}-{3:3}, at: jbd2_journal_flush+0x48f/0xc10

stack backtrace:
CPU: 0 PID: 11104 Comm: syz-executor.1 Not tainted 6.1.0-rc4-next-20221109 #1
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014
Call Trace:
 <TASK>
 dump_stack_lvl+0x8f/0xb7
 check_noncircular+0x263/0x2e0
 __lock_acquire+0x2a02/0x5e70
 lock_acquire+0x1a6/0x530
 down_read+0x9c/0x450
 ext4_bmap+0x52/0x470
 bmap+0xb0/0x130
 jbd2_journal_bmap+0xac/0x190
 jbd2_journal_flush+0x857/0xc10
 __ext4_ioctl+0x9c1/0x4140
 __x64_sys_ioctl+0x19e/0x210
 do_syscall_64+0x3f/0x90
 entry_SYSCALL_64_after_hwframe+0x72/0xdc
RIP: 0033:0x7f54e73f5b19
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f54e496b188 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007f54e7508f60 RCX: 00007f54e73f5b19
RDX: 0000000020000040 RSI: 000000004004662b RDI: 0000000000000006
RBP: 00007f54e744ff6d R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ffea4f90abf R14: 00007f54e496b300 R15: 0000000000022000
 </TASK>
FAULT_INJECTION: forcing a failure.
name fail_usercopy, interval 1, probability 0, space 0, times 0
CPU: 1 PID: 11108 Comm: syz-executor.0 Not tainted 6.1.0-rc4-next-20221109 #1
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014
Call Trace:
 <TASK>
 dump_stack_lvl+0x8f/0xb7
 should_fail.cold+0x5/0xa
 _copy_from_user+0x2e/0x180
 copy_clone_args_from_user+0x147/0x790
 __do_sys_clone3+0x8f/0x2e0
 do_syscall_64+0x3f/0x90
 entry_SYSCALL_64_after_hwframe+0x72/0xdc
RIP: 0033:0x7f42c779db19
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f42c4d13188 EFLAGS: 00000246 ORIG_RAX: 00000000000001b3
RAX: ffffffffffffffda RBX: 00007f42c78b0f60 RCX: 00007f42c779db19
RDX: 0000000000000000 RSI: 0000000000000058 RDI: 0000000020004c00
RBP: 00007f42c4d131d0 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000001
R13: 00007ffd5906da2f R14: 00007f42c4d13300 R15: 0000000000022000
 </TASK>
SELinux: unrecognized netlink message: protocol=4 nlmsg_type=16 sclass=netlink_tcpdiag_socket pid=11107 comm=syz-executor.7
syz_tun: refused to change device tx_queue_len
SELinux: unrecognized netlink message: protocol=4 nlmsg_type=0 sclass=netlink_tcpdiag_socket pid=11107 comm=syz-executor.7
SELinux: unrecognized netlink message: protocol=4 nlmsg_type=16 sclass=netlink_tcpdiag_socket pid=11124 comm=syz-executor.7
SELinux: unrecognized netlink message: protocol=4 nlmsg_type=0 sclass=netlink_tcpdiag_socket pid=11130 comm=syz-executor.7
FAULT_INJECTION: forcing a failure.
name fail_usercopy, interval 1, probability 0, space 0, times 0
CPU: 0 PID: 11131 Comm: syz-executor.5 Not tainted 6.1.0-rc4-next-20221109 #1
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014
Call Trace:
 <TASK>
 dump_stack_lvl+0x8f/0xb7
 should_fail.cold+0x5/0xa
 _copy_from_user+0x2e/0x180
 memdup_user+0x72/0xd0
 __tun_chr_ioctl+0x3366/0x3f40
 __x64_sys_ioctl+0x19e/0x210
 do_syscall_64+0x3f/0x90
 entry_SYSCALL_64_after_hwframe+0x72/0xdc
RIP: 0033:0x7f05b8551b19
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f05b5ac7188 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007f05b8664f60 RCX: 00007f05b8551b19
RDX: 0000000020000140 RSI: 00000000400454d1 RDI: 0000000000000003
RBP: 00007f05b5ac71d0 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000001
R13: 00007ffe741ae0cf R14: 00007f05b5ac7300 R15: 0000000000022000
 </TASK>
syz_tun: refused to change device tx_queue_len