WARNING: possible circular locking dependency detected
6.3.0-rc1-next-20230308 #1 Not tainted
------------------------------------------------------
syz-executor.7/14848 is trying to acquire lock:
ffff88800ff14990 (jbd2_handle){++++}-{0:0}, at: jbd2_log_wait_commit+0x146/0x440

but task is already holding lock:
ffff888048b36760 (&type->i_mutex_dir_key#3/4){+.+.}-{3:3}, at: ext4_rename+0x18f1/0x2cc0

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&type->i_mutex_dir_key#3/4){+.+.}-{3:3}:
       down_write_nested+0x96/0x1f0
       ext4_rename+0x18f1/0x2cc0
       ext4_rename2+0x1d3/0x260
       vfs_rename+0xefc/0x17a0
       do_renameat2+0x55f/0xc30
       __x64_sys_rename+0x81/0xa0
       do_syscall_64+0x3f/0x90
       entry_SYSCALL_64_after_hwframe+0x72/0xdc

-> #0 (jbd2_handle){++++}-{0:0}:
       __lock_acquire+0x2d56/0x6380
       lock_acquire.part.0+0xea/0x320
       jbd2_log_wait_commit+0x17b/0x440
       jbd2_journal_stop+0xa70/0xed0
       __ext4_journal_stop+0xe2/0x1f0
       ext4_rename+0x179f/0x2cc0
       ext4_rename2+0x1d3/0x260
       vfs_rename+0xefc/0x17a0
       do_renameat2+0x55f/0xc30
       __x64_sys_rename+0x81/0xa0
       do_syscall_64+0x3f/0x90
       entry_SYSCALL_64_after_hwframe+0x72/0xdc

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&type->i_mutex_dir_key#3/4);
                               lock(jbd2_handle);
                               lock(&type->i_mutex_dir_key#3/4);
  lock(jbd2_handle);

 *** DEADLOCK ***

6 locks held by syz-executor.7/14848:
 #0: ffff88800ff10438 (sb_writers#3){.+.+}-{0:0}, at: do_renameat2+0x372/0xc30
 #1: ffff88800ff10720 (&type->s_vfs_rename_key#2){+.+.}-{3:3}, at: lock_rename+0x58/0x290
 #2: ffff88801b9397e0 (&type->i_mutex_dir_key#3/1){+.+.}-{3:3}, at: lock_rename+0x13a/0x290
 #3: ffff888048b335b0 (&type->i_mutex_dir_key#3/2){+.+.}-{3:3}, at: lock_rename+0x16e/0x290
 #4: ffff888048b35d70 (&type->i_mutex_dir_key#3){++++}-{3:3}, at: vfs_rename+0x4f9/0x17a0
 #5: ffff888048b36760 (&type->i_mutex_dir_key#3/4){+.+.}-{3:3}, at: ext4_rename+0x18f1/0x2cc0

stack backtrace:
CPU: 0 PID: 14848 Comm: syz-executor.7 Not tainted 6.3.0-rc1-next-20230308 #1
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014
Call Trace:
 <TASK>
 dump_stack_lvl+0x91/0xf0
 check_noncircular+0x263/0x2e0
 __lock_acquire+0x2d56/0x6380
 lock_acquire.part.0+0xea/0x320
 jbd2_log_wait_commit+0x17b/0x440
 jbd2_journal_stop+0xa70/0xed0
 __ext4_journal_stop+0xe2/0x1f0
 ext4_rename+0x179f/0x2cc0
 ext4_rename2+0x1d3/0x260
 vfs_rename+0xefc/0x17a0
 do_renameat2+0x55f/0xc30
 __x64_sys_rename+0x81/0xa0
 do_syscall_64+0x3f/0x90
 entry_SYSCALL_64_after_hwframe+0x72/0xdc
RIP: 0033:0x7f2de2331b19
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f2ddf8a7188 EFLAGS: 00000246 ORIG_RAX: 0000000000000052
RAX: ffffffffffffffda RBX: 00007f2de2444f60 RCX: 00007f2de2331b19
RDX: 0000000000000000 RSI: 0000000020000180 RDI: 00000000200000c0
RBP: 00007f2de238bf6d R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ffde109985f R14: 00007f2ddf8a7300 R15: 0000000000022000
 </TASK>