======================================================== WARNING: possible irq lock inversion dependency detected 6.4.0-rc7-next-20230621 #1 Not tainted -------------------------------------------------------- syz-executor.6/9363 just changed the state of lock: ffffffff85814e18 (blkg_stat_lock){+.-.}-{2:2}, at: __blkcg_rstat_flush.isra.0+0x11f/0x4e0 but this lock was taken by another, HARDIRQ-safe lock in the past: (per_cpu_ptr(&cgroup_rstat_cpu_lock, cpu)){-.-.}-{2:2} and interrupts could create inverse lock ordering between them. other info that might help us debug this: Possible interrupt unsafe locking scenario: CPU0 CPU1 ---- ---- lock(blkg_stat_lock); local_irq_disable(); lock(per_cpu_ptr(&cgroup_rstat_cpu_lock, cpu)); lock(blkg_stat_lock); lock(per_cpu_ptr(&cgroup_rstat_cpu_lock, cpu)); *** DEADLOCK *** 8 locks held by syz-executor.6/9363: #0: ffff88803737eac8 (&f->f_pos_lock){+.+.}-{3:3}, at: __fdget_pos+0xdf/0x100 #1: ffff88801002a3e8 (sb_writers#3){.+.+}-{0:0}, at: ksys_write+0x122/0x250 #2: ffff88803a40b588 (&sb->s_type->i_mutex_key#6){++++}-{3:3}, at: ext4_file_write_iter+0x3e7/0x19b0 #3: ffff88801002cbd0 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: do_writepages+0x1ad/0x650 #4: ffff88801002e988 (jbd2_handle){++++}-{0:0}, at: start_this_handle+0xf9f/0x14c0 #5: ffff88803a40b8d0 (&ei->i_raw_lock){+.+.}-{2:2}, at: ext4_mark_iloc_dirty+0x1a7/0x1b30 #6: ffffffff8560b520 (rcu_callback){....}-{0:0}, at: rcu_core+0x83e/0x2860 #7: ffffffff8560b640 (rcu_read_lock){....}-{1:2}, at: __blkcg_rstat_flush.isra.0+0x93/0x4e0 the shortest dependencies between 2nd lock and 1st lock: -> (per_cpu_ptr(&cgroup_rstat_cpu_lock, cpu)){-.-.}-{2:2} { IN-HARDIRQ-W at: lock_acquire+0x19a/0x4c0 _raw_spin_lock_irqsave+0x3a/0x60 cgroup_rstat_updated+0xcb/0x2e0 __cgroup_account_cputime_field+0xa0/0x120 account_system_index_time+0x199/0x2c0 update_process_times+0x26/0x150 tick_sched_handle+0x8e/0x170 tick_sched_timer+0xe6/0x110 __hrtimer_run_queues+0x17f/0xb60 hrtimer_interrupt+0x2ef/0x750 __sysvec_apic_timer_interrupt+0xff/0x380 sysvec_apic_timer_interrupt+0x69/0x90 asm_sysvec_apic_timer_interrupt+0x1a/0x20 _raw_spin_unlock_irq+0x2b/0x40 cgroup_migrate_execute+0x637/0x1190 cgroup_attach_task+0x441/0x750 __cgroup_procs_write+0x35c/0x6b0 cgroup_procs_write+0x26/0x60 cgroup_file_write+0x1e5/0x7c0 kernfs_fop_write_iter+0x3f7/0x610 vfs_write+0x97d/0xda0 ksys_write+0x122/0x250 do_syscall_64+0x3f/0x90 entry_SYSCALL_64_after_hwframe+0x6e/0xd8 IN-SOFTIRQ-W at: lock_acquire+0x19a/0x4c0 _raw_spin_lock_irqsave+0x3a/0x60 cgroup_rstat_updated+0xcb/0x2e0 __mod_memcg_state+0x86/0x160 memcg_account_kmem+0x38/0x70 refill_obj_stock+0x35f/0x5c0 kmem_cache_free+0x444/0x4d0 i_callback+0x46/0x70 rcu_core+0x8c8/0x2860 __do_softirq+0x1b7/0x7d4 irq_exit_rcu+0x93/0xc0 sysvec_apic_timer_interrupt+0x6e/0x90 asm_sysvec_apic_timer_interrupt+0x1a/0x20 unwind_next_frame+0x1685/0x2490 arch_stack_walk+0x87/0xf0 stack_trace_save+0x90/0xd0 kasan_save_stack+0x22/0x50 __kasan_record_aux_stack+0x8e/0xa0 __call_rcu_common.constprop.0+0x6a/0xb90 kmem_cache_free+0xc1/0x4d0 mas_destroy+0x1fe/0x8b0 mas_store_prealloc+0xf4/0x160 mmap_region+0x1229/0x26c0 do_mmap+0x854/0xf00 vm_mmap_pgoff+0x1a6/0x3a0 ksys_mmap_pgoff+0x3af/0x500 do_syscall_64+0x3f/0x90 entry_SYSCALL_64_after_hwframe+0x6e/0xd8 INITIAL USE at: lock_acquire+0x19a/0x4c0 _raw_spin_lock_irqsave+0x3a/0x60 cgroup_rstat_flush_locked+0x131/0xd80 cgroup_rstat_flush+0x37/0x50 do_flush_stats+0x97/0xf0 flush_memcg_stats_dwork+0x9/0x50 process_one_work+0xabf/0x1770 worker_thread+0x64f/0x12a0 kthread+0x33f/0x440 ret_from_fork+0x2c/0x50 } ... key at: [] __key.0+0x0/0x40 ... acquired at: _raw_spin_lock+0x2b/0x40 __blkcg_rstat_flush.isra.0+0x11f/0x4e0 blkcg_rstat_flush+0x87/0xb0 cgroup_rstat_flush_locked+0x706/0xd80 cgroup_rstat_flush+0x37/0x50 do_flush_stats+0x97/0xf0 mem_cgroup_wb_stats+0x3d8/0x4b0 balance_dirty_pages+0x339/0x2640 balance_dirty_pages_ratelimited_flags+0xbce/0x1130 fault_dirty_shared_page+0x2b3/0x500 do_wp_page+0x3c8/0x3a50 __handle_mm_fault+0xc5b/0x2eb0 handle_mm_fault+0x1af/0xba0 do_user_addr_fault+0x56b/0x12d0 exc_page_fault+0x9c/0x1a0 asm_exc_page_fault+0x26/0x30 -> (blkg_stat_lock){+.-.}-{2:2} { HARDIRQ-ON-W at: lock_acquire+0x19a/0x4c0 _raw_spin_lock+0x2b/0x40 __blkcg_rstat_flush.isra.0+0x11f/0x4e0 __blkg_release+0xfa/0x3b0 rcu_core+0x8c8/0x2860 __do_softirq+0x1b7/0x7d4 irq_exit_rcu+0x93/0xc0 common_interrupt+0x7c/0xa0 asm_common_interrupt+0x26/0x40 lock_acquire+0x1c7/0x4c0 _raw_spin_lock+0x2b/0x40 ext4_mark_iloc_dirty+0x1a7/0x1b30 __ext4_mark_inode_dirty+0x207/0x7b0 ext4_do_writepages+0x20c3/0x3150 ext4_writepages+0x2fc/0x760 do_writepages+0x1ad/0x650 filemap_fdatawrite_wbc+0x14b/0x1b0 __filemap_fdatawrite_range+0xba/0x100 filemap_write_and_wait_range.part.0+0x89/0x110 kiocb_invalidate_pages+0xe6/0x180 __iomap_dio_rw+0xedd/0x1d00 iomap_dio_rw+0x40/0xa0 ext4_file_write_iter+0xad6/0x19b0 vfs_write+0x97d/0xda0 ksys_write+0x122/0x250 do_syscall_64+0x3f/0x90 entry_SYSCALL_64_after_hwframe+0x6e/0xd8 IN-SOFTIRQ-W at: lock_acquire+0x19a/0x4c0 _raw_spin_lock+0x2b/0x40 __blkcg_rstat_flush.isra.0+0x11f/0x4e0 __blkg_release+0xfa/0x3b0 rcu_core+0x8c8/0x2860 __do_softirq+0x1b7/0x7d4 irq_exit_rcu+0x93/0xc0 common_interrupt+0x7c/0xa0 asm_common_interrupt+0x26/0x40 lock_acquire+0x1c7/0x4c0 _raw_spin_lock+0x2b/0x40 ext4_mark_iloc_dirty+0x1a7/0x1b30 __ext4_mark_inode_dirty+0x207/0x7b0 ext4_do_writepages+0x20c3/0x3150 ext4_writepages+0x2fc/0x760 do_writepages+0x1ad/0x650 filemap_fdatawrite_wbc+0x14b/0x1b0 __filemap_fdatawrite_range+0xba/0x100 filemap_write_and_wait_range.part.0+0x89/0x110 kiocb_invalidate_pages+0xe6/0x180 __iomap_dio_rw+0xedd/0x1d00 iomap_dio_rw+0x40/0xa0 ext4_file_write_iter+0xad6/0x19b0 vfs_write+0x97d/0xda0 ksys_write+0x122/0x250 do_syscall_64+0x3f/0x90 entry_SYSCALL_64_after_hwframe+0x6e/0xd8 INITIAL USE at: lock_acquire+0x19a/0x4c0 _raw_spin_lock+0x2b/0x40 __blkcg_rstat_flush.isra.0+0x11f/0x4e0 blkcg_rstat_flush+0x87/0xb0 cgroup_rstat_flush_locked+0x706/0xd80 cgroup_rstat_flush+0x37/0x50 do_flush_stats+0x97/0xf0 mem_cgroup_wb_stats+0x3d8/0x4b0 balance_dirty_pages+0x339/0x2640 balance_dirty_pages_ratelimited_flags+0xbce/0x1130 fault_dirty_shared_page+0x2b3/0x500 do_wp_page+0x3c8/0x3a50 __handle_mm_fault+0xc5b/0x2eb0 handle_mm_fault+0x1af/0xba0 do_user_addr_fault+0x56b/0x12d0 exc_page_fault+0x9c/0x1a0 asm_exc_page_fault+0x26/0x30 } ... key at: [] blkg_stat_lock+0x18/0x60 ... acquired at: __lock_acquire+0x8b8/0x6340 lock_acquire+0x19a/0x4c0 _raw_spin_lock+0x2b/0x40 __blkcg_rstat_flush.isra.0+0x11f/0x4e0 __blkg_release+0xfa/0x3b0 rcu_core+0x8c8/0x2860 __do_softirq+0x1b7/0x7d4 irq_exit_rcu+0x93/0xc0 common_interrupt+0x7c/0xa0 asm_common_interrupt+0x26/0x40 lock_acquire+0x1c7/0x4c0 _raw_spin_lock+0x2b/0x40 ext4_mark_iloc_dirty+0x1a7/0x1b30 __ext4_mark_inode_dirty+0x207/0x7b0 ext4_do_writepages+0x20c3/0x3150 ext4_writepages+0x2fc/0x760 do_writepages+0x1ad/0x650 filemap_fdatawrite_wbc+0x14b/0x1b0 __filemap_fdatawrite_range+0xba/0x100 filemap_write_and_wait_range.part.0+0x89/0x110 kiocb_invalidate_pages+0xe6/0x180 __iomap_dio_rw+0xedd/0x1d00 iomap_dio_rw+0x40/0xa0 ext4_file_write_iter+0xad6/0x19b0 vfs_write+0x97d/0xda0 ksys_write+0x122/0x250 do_syscall_64+0x3f/0x90 entry_SYSCALL_64_after_hwframe+0x6e/0xd8 stack backtrace: CPU: 0 PID: 9363 Comm: syz-executor.6 Not tainted 6.4.0-rc7-next-20230621 #1 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014 Call Trace: dump_stack_lvl+0x91/0xf0 print_irq_inversion_bug.part.0+0x3d5/0x570 mark_lock.part.0+0x900/0x2f50 __lock_acquire+0x8b8/0x6340 lock_acquire+0x19a/0x4c0 _raw_spin_lock+0x2b/0x40 __blkcg_rstat_flush.isra.0+0x11f/0x4e0 __blkg_release+0xfa/0x3b0 rcu_core+0x8c8/0x2860 __do_softirq+0x1b7/0x7d4 irq_exit_rcu+0x93/0xc0 common_interrupt+0x7c/0xa0 asm_common_interrupt+0x26/0x40 RIP: 0010:lock_acquire+0x1c7/0x4c0 Code: ff ff 48 83 c4 28 65 0f c1 05 05 f6 d4 7e 83 f8 01 0f 85 8f 02 00 00 48 83 7c 24 08 00 74 01 fb 48 b8 00 00 00 00 00 fc ff df <48> 01 c3 48 c7 03 00 00 00 00 48 c7 43 08 00 00 00 00 48 8b 84 24 RSP: 0018:ffff88803c3b70c8 EFLAGS: 00000206 RAX: dffffc0000000000 RBX: 1ffff11007876e1b RCX: 0000000000000001 RDX: 1ffff1100725b80d RSI: 0000000000000008 RDI: ffffffff87217798 RBP: 0000000000000001 R08: 0000000000000000 R09: fffffbfff0ef8170 R10: ffffffff877c0b87 R11: 0000000000000001 R12: 0000000000000000 R13: 0000000000000000 R14: ffff88803a40b8d0 R15: 0000000000000000 _raw_spin_lock+0x2b/0x40 ext4_mark_iloc_dirty+0x1a7/0x1b30 __ext4_mark_inode_dirty+0x207/0x7b0 ext4_do_writepages+0x20c3/0x3150 ext4_writepages+0x2fc/0x760 do_writepages+0x1ad/0x650 filemap_fdatawrite_wbc+0x14b/0x1b0 __filemap_fdatawrite_range+0xba/0x100 filemap_write_and_wait_range.part.0+0x89/0x110 kiocb_invalidate_pages+0xe6/0x180 __iomap_dio_rw+0xedd/0x1d00 iomap_dio_rw+0x40/0xa0 ext4_file_write_iter+0xad6/0x19b0 vfs_write+0x97d/0xda0 ksys_write+0x122/0x250 do_syscall_64+0x3f/0x90 entry_SYSCALL_64_after_hwframe+0x6e/0xd8 RIP: 0033:0x7f8a48ca3b19 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f8a46219188 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 RAX: ffffffffffffffda RBX: 00007f8a48db6f60 RCX: 00007f8a48ca3b19 RDX: 0000000000140000 RSI: 0000000020000200 RDI: 0000000000000003 RBP: 00007f8a48cfdf6d R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007fffa0b0dc0f R14: 00007f8a46219300 R15: 0000000000022000 ---------------- Code disassembly (best guess), 2 bytes skipped: 0: 48 83 c4 28 add $0x28,%rsp 4: 65 0f c1 05 05 f6 d4 xadd %eax,%gs:0x7ed4f605(%rip) # 0x7ed4f611 b: 7e c: 83 f8 01 cmp $0x1,%eax f: 0f 85 8f 02 00 00 jne 0x2a4 15: 48 83 7c 24 08 00 cmpq $0x0,0x8(%rsp) 1b: 74 01 je 0x1e 1d: fb sti 1e: 48 b8 00 00 00 00 00 movabs $0xdffffc0000000000,%rax 25: fc ff df * 28: 48 01 c3 add %rax,%rbx <-- trapping instruction 2b: 48 c7 03 00 00 00 00 movq $0x0,(%rbx) 32: 48 c7 43 08 00 00 00 movq $0x0,0x8(%rbx) 39: 00 3a: 48 rex.W 3b: 8b .byte 0x8b 3c: 84 .byte 0x84 3d: 24 .byte 0x24