======================================================
WARNING: possible circular locking dependency detected
6.2.0-next-20230227 #1 Not tainted
------------------------------------------------------
syz-executor.1/5980 is trying to acquire lock:
ffff88801009c170 (&journal->j_barrier){+.+.}-{3:3}, at: jbd2_journal_lock_updates+0x162/0x310
but task is already holding lock:
ffff88801009ab90 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_change_inode_journal_flag+0x17f/0x550
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #3 (&sbi->s_writepages_rwsem){++++}-{0:0}:
ext4_writepages+0x1a9/0x5e0
do_writepages+0x1ad/0x650
filemap_fdatawrite_wbc+0x14b/0x1b0
__filemap_fdatawrite_range+0xba/0x100
ext4_alloc_da_blocks+0x1bc/0x300
ext4_ind_migrate+0x706/0x840
ext4_fileattr_set+0x1521/0x19f0
vfs_fileattr_set+0x7a2/0xbd0
do_vfs_ioctl+0xfc1/0x1690
__x64_sys_ioctl+0x110/0x210
do_syscall_64+0x3f/0x90
entry_SYSCALL_64_after_hwframe+0x72/0xdc
-> #2 (&sb->s_type->i_mutex_key#6){++++}-{3:3}:
down_read+0x3d/0x50
ext4_bmap+0x52/0x470
bmap+0xb0/0x130
jbd2_journal_bmap+0xac/0x1d0
jbd2_journal_flush+0x87f/0xc90
__ext4_ioctl+0x9fd/0x4330
__x64_sys_ioctl+0x19e/0x210
do_syscall_64+0x3f/0x90
entry_SYSCALL_64_after_hwframe+0x72/0xdc
-> #1 (&journal->j_checkpoint_mutex){+.+.}-{3:3}:
mutex_lock_io_nested+0x149/0x1300
jbd2_journal_flush+0x19e/0xc90
__ext4_ioctl+0x9fd/0x4330
__x64_sys_ioctl+0x19e/0x210
do_syscall_64+0x3f/0x90
entry_SYSCALL_64_after_hwframe+0x72/0xdc
-> #0 (&journal->j_barrier){+.+.}-{3:3}:
__lock_acquire+0x2d56/0x6380
lock_acquire.part.0+0xea/0x320
__mutex_lock+0x133/0x14a0
jbd2_journal_lock_updates+0x162/0x310
ext4_change_inode_journal_flag+0x187/0x550
ext4_fileattr_set+0x14fa/0x19f0
vfs_fileattr_set+0x7a2/0xbd0
do_vfs_ioctl+0xfc1/0x1690
__x64_sys_ioctl+0x110/0x210
do_syscall_64+0x3f/0x90
entry_SYSCALL_64_after_hwframe+0x72/0xdc
FAULT_INJECTION: forcing a failure.
name fail_usercopy, interval 1, probability 0, space 0, times 1
other info that might help us debug this:
Chain exists of:
&journal->j_barrier
CPU: 0 PID: 5975 Comm: syz-executor.0 Not tainted 6.2.0-next-20230227 #1
-->
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014
&sb->s_type->i_mutex_key
Call Trace:
#6
dump_stack_lvl+0xc1/0xf0
-->
should_fail_ex+0x4b4/0x5b0
&sbi->s_writepages_rwsem
_copy_to_user+0x2e/0x150
simple_read_from_buffer+0xd0/0x170
Possible unsafe locking scenario:
proc_fail_nth_read+0x19c/0x230
CPU0 CPU1
---- ----
lock(
vfs_read+0x257/0x940
&sbi->s_writepages_rwsem
);
lock(
&sb->s_type->i_mutex_key
#6
ksys_read+0x12b/0x260
);
lock(
do_syscall_64+0x3f/0x90
&sbi->s_writepages_rwsem
entry_SYSCALL_64_after_hwframe+0x72/0xdc
);
RIP: 0033:0x7f57df67569c
lock(
Code: ec 28 48 89 54 24 18 48 89 74 24 10 89 7c 24 08 e8 f9 fc ff ff 48 8b 54 24 18 48 8b 74 24 10 41 89 c0 8b 7c 24 08 31 c0 0f 05 <48> 3d 00 f0 ff ff 77 34 44 89 c7 48 89 44 24 08 e8 2f fd ff ff 48
&journal->j_barrier
RSP: 002b:00007f57dcc38170 EFLAGS: 00000246
);
ORIG_RAX: 0000000000000000
RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f57df67569c
*** DEADLOCK ***
RDX: 000000000000000f RSI: 00007f57dcc381e0 RDI: 0000000000000003
4 locks held by syz-executor.1/5980:
RBP: 00007f57dcc381d0 R08: 0000000000000000 R09: 0000000000000000
#0:
R10: 0000000000000004 R11: 0000000000000246 R12: 0000000000000001
ffff888010098438
R13: 00007ffcff1aa81f R14: 00007f57dcc38300 R15: 0000000000022000
(
sb_writers#3){.+.+}-{0:0}, at: do_vfs_ioctl+0xf86/0x1690
#1: ffff88801bb2dd70 (&sb->s_type->i_mutex_key#6){++++}-{3:3}, at: vfs_fileattr_set+0x14c/0xbd0
#2: ffff88801bb2df10 (mapping.invalidate_lock){++++}-{3:3}, at: ext4_change_inode_journal_flag+0x126/0x550
#3: ffff88801009ab90 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_change_inode_journal_flag+0x17f/0x550
stack backtrace:
CPU: 1 PID: 5980 Comm: syz-executor.1 Not tainted 6.2.0-next-20230227 #1
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014
Call Trace:
dump_stack_lvl+0x91/0xf0
check_noncircular+0x263/0x2e0
__lock_acquire+0x2d56/0x6380
lock_acquire.part.0+0xea/0x320
__mutex_lock+0x133/0x14a0
jbd2_journal_lock_updates+0x162/0x310
ext4_change_inode_journal_flag+0x187/0x550
ext4_fileattr_set+0x14fa/0x19f0
vfs_fileattr_set+0x7a2/0xbd0
do_vfs_ioctl+0xfc1/0x1690
__x64_sys_ioctl+0x110/0x210
do_syscall_64+0x3f/0x90
entry_SYSCALL_64_after_hwframe+0x72/0xdc
RIP: 0033:0x7f378fda2b19
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f378d318188 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007f378feb5f60 RCX: 00007f378fda2b19
RDX: 0000000020000040 RSI: 0000000040086602 RDI: 0000000000000004
RBP: 00007f378fdfcf6d R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ffd7d4504ff R14: 00007f378d318300 R15: 0000000000022000
9pnet_fd: Insufficient options for proto=fd
----------------
Code disassembly (best guess):
0: ec in (%dx),%al
1: 28 48 89 sub %cl,-0x77(%rax)
4: 54 push %rsp
5: 24 18 and $0x18,%al
7: 48 89 74 24 10 mov %rsi,0x10(%rsp)
c: 89 7c 24 08 mov %edi,0x8(%rsp)
10: e8 f9 fc ff ff callq 0xfffffd0e
15: 48 8b 54 24 18 mov 0x18(%rsp),%rdx
1a: 48 8b 74 24 10 mov 0x10(%rsp),%rsi
1f: 41 89 c0 mov %eax,%r8d
22: 8b 7c 24 08 mov 0x8(%rsp),%edi
26: 31 c0 xor %eax,%eax
28: 0f 05 syscall
* 2a: 48 3d 00 f0 ff ff cmp $0xfffffffffffff000,%rax <-- trapping instruction
30: 77 34 ja 0x66
32: 44 89 c7 mov %r8d,%edi
35: 48 89 44 24 08 mov %rax,0x8(%rsp)
3a: e8 2f fd ff ff callq 0xfffffd6e
3f: 48 rex.W