======================================================
WARNING: possible circular locking dependency detected
6.2.0-next-20230303 #1 Not tainted
------------------------------------------------------
syz-executor.0/7954 is trying to acquire lock:
ffff88800ff96170 (&journal->j_barrier){+.+.}-{3:3}, at: jbd2_journal_lock_updates+0x162/0x310

but task is already holding lock:
ffff88800ff94b90 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_change_inode_journal_flag+0x17f/0x550

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&sbi->s_writepages_rwsem){++++}-{0:0}:
       percpu_down_write+0x51/0x350
       ext4_ind_migrate+0x23b/0x840
       ext4_fileattr_set+0x1521/0x19f0
       vfs_fileattr_set+0x7a2/0xbd0
       do_vfs_ioctl+0xfc1/0x1690
       __x64_sys_ioctl+0x110/0x210
       do_syscall_64+0x3f/0x90
       entry_SYSCALL_64_after_hwframe+0x72/0xdc

-> #2 (&sb->s_type->i_mutex_key#6){++++}-{3:3}:
       down_read+0x3d/0x50
       ext4_bmap+0x52/0x470
       bmap+0xb0/0x130
       jbd2_journal_bmap+0xac/0x1d0
       jbd2_journal_flush+0x87f/0xc90
       __ext4_ioctl+0x9fd/0x4330
       __x64_sys_ioctl+0x19e/0x210
       do_syscall_64+0x3f/0x90
       entry_SYSCALL_64_after_hwframe+0x72/0xdc

-> #1 (&journal->j_checkpoint_mutex){+.+.}-{3:3}:
       mutex_lock_io_nested+0x149/0x1300
       jbd2_journal_flush+0x19e/0xc90
       __ext4_ioctl+0x9fd/0x4330
       __x64_sys_ioctl+0x19e/0x210
       do_syscall_64+0x3f/0x90
       entry_SYSCALL_64_after_hwframe+0x72/0xdc

-> #0 (&journal->j_barrier){+.+.}-{3:3}:
       __lock_acquire+0x2d56/0x6380
       lock_acquire.part.0+0xea/0x320
       __mutex_lock+0x133/0x14a0
       jbd2_journal_lock_updates+0x162/0x310
       ext4_change_inode_journal_flag+0x187/0x550
       ext4_fileattr_set+0x14fa/0x19f0
       vfs_fileattr_set+0x7a2/0xbd0
       do_vfs_ioctl+0xfc1/0x1690
       __x64_sys_ioctl+0x110/0x210
       do_syscall_64+0x3f/0x90
       entry_SYSCALL_64_after_hwframe+0x72/0xdc

other info that might help us debug this:

Chain exists of:
  &journal->j_barrier --> &sb->s_type->i_mutex_key#6 --> &sbi->s_writepages_rwsem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&sbi->s_writepages_rwsem);
                               lock(&sb->s_type->i_mutex_key#6);
                               lock(&sbi->s_writepages_rwsem);
  lock(&journal->j_barrier);

 *** DEADLOCK ***

4 locks held by syz-executor.0/7954:
 #0: ffff88800ff92438 (sb_writers#3){.+.+}-{0:0}, at: do_vfs_ioctl+0xf86/0x1690
 #1: ffff88801c3bd380 (&sb->s_type->i_mutex_key#6){++++}-{3:3}, at: vfs_fileattr_set+0x14c/0xbd0
 #2: ffff88801c3bd520 (mapping.invalidate_lock){++++}-{3:3}, at: ext4_change_inode_journal_flag+0x126/0x550
 #3: ffff88800ff94b90 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_change_inode_journal_flag+0x17f/0x550

stack backtrace:
CPU: 0 PID: 7954 Comm: syz-executor.0 Not tainted 6.2.0-next-20230303 #1
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014
Call Trace:
 <TASK>
 dump_stack_lvl+0x91/0xf0
 check_noncircular+0x263/0x2e0
 __lock_acquire+0x2d56/0x6380
 lock_acquire.part.0+0xea/0x320
 __mutex_lock+0x133/0x14a0
 jbd2_journal_lock_updates+0x162/0x310
 ext4_change_inode_journal_flag+0x187/0x550
 ext4_fileattr_set+0x14fa/0x19f0
 vfs_fileattr_set+0x7a2/0xbd0
 do_vfs_ioctl+0xfc1/0x1690
 __x64_sys_ioctl+0x110/0x210
 do_syscall_64+0x3f/0x90
 entry_SYSCALL_64_after_hwframe+0x72/0xdc
RIP: 0033:0x7f6b8625bb19
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f6b837d1188 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007f6b8636ef60 RCX: 00007f6b8625bb19
RDX: 0000000020000040 RSI: 0000000040086602 RDI: 0000000000000003
RBP: 00007f6b862b5f6d R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ffc9420ca8f R14: 00007f6b837d1300 R15: 0000000000022000
 </TASK>
SELinux: security_context_str_to_sid (system_u) failed with errno=-22
FAULT_INJECTION: forcing a failure.
name failslab, interval 1, probability 0, space 0, times 0
CPU: 0 PID: 7953 Comm: syz-executor.5 Not tainted 6.2.0-next-20230303 #1
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014
Call Trace:
 <TASK>
 dump_stack_lvl+0xc1/0xf0
 should_fail_ex+0x4b4/0x5b0
 should_failslab+0x9/0x20
 __kmem_cache_alloc_node+0x5b/0x310
 __kmalloc+0x46/0xc0
 ext4_find_extent+0xa41/0xd30
 ext4_ext_map_blocks+0x1c7/0x5dd0
SELinux: security_context_str_to_sid (system_u) failed with errno=-22
 ext4_map_blocks+0x776/0x19e0
 ext4_getblk+0x62d/0x860
 ext4_bread+0x2e/0x1a0
 ext4_append+0x21d/0x530
 ext4_init_new_dir+0x262/0x4c0
 ext4_mkdir+0x3d3/0xb20
 vfs_mkdir+0x24b/0x470
 do_mkdirat+0x163/0x2d0
 __x64_sys_mkdir+0xf6/0x150
 do_syscall_64+0x3f/0x90
 entry_SYSCALL_64_after_hwframe+0x72/0xdc
RIP: 0033:0x7fefb1351b19
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fefae8c7188 EFLAGS: 00000246 ORIG_RAX: 0000000000000053
RAX: ffffffffffffffda RBX: 00007fefb1464f60 RCX: 00007fefb1351b19
RDX: 0000000000000000 RSI: 0000000000000080 RDI: 0000000020000240
RBP: 00007fefae8c71d0 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000002
R13: 00007ffc33f6032f R14: 00007fefae8c7300 R15: 0000000000022000
 </TASK>
FAULT_INJECTION: forcing a failure.
name failslab, interval 1, probability 0, space 0, times 0
CPU: 0 PID: 7965 Comm: syz-executor.2 Not tainted 6.2.0-next-20230303 #1
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014
Call Trace:
 <TASK>
 dump_stack_lvl+0xc1/0xf0
 should_fail_ex+0x4b4/0x5b0
 should_failslab+0x9/0x20
 __kmem_cache_alloc_node+0x5b/0x310
 __kmalloc_node_track_caller+0x43/0xb0
 kstrdup+0x3f/0x80
 kstrdup_const+0x57/0x80
 alloc_vfsmnt+0xb5/0x6c0
 clone_mnt+0x6c/0xd80
 copy_tree+0x3b4/0xa60
 copy_mnt_ns+0x1a9/0xae0
 create_new_namespaces+0xd6/0xb30
 copy_namespaces+0x414/0x500
 copy_process+0x2a5e/0x7390
 kernel_clone+0xeb/0x8c0
 __do_sys_clone3+0x1d5/0x2e0
 do_syscall_64+0x3f/0x90
 entry_SYSCALL_64_after_hwframe+0x72/0xdc
RIP: 0033:0x7fbfb4cfab19
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fbfb2270188 EFLAGS: 00000246 ORIG_RAX: 00000000000001b3
RAX: ffffffffffffffda RBX: 00007fbfb4e0df60 RCX: 00007fbfb4cfab19
RDX: 0000000000000000 RSI: 000000000000004e RDI: 00000000200003c0
RBP: 00007fbfb22701d0 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000002
R13: 00007fff0e95b7df R14: 00007fbfb2270300 R15: 0000000000022000
 </TASK>
cgroup: Unknown subsys name ''
SELinux:  Context system_u:object_r:dhcpd_unit_file_t:s0 is not valid (left unmapped).
audit: type=1400 audit(1677909862.720:16): avc:  denied  { associate } for  pid=7981 comm="syz-executor.0" name="ssh.service" dev="cgroup2" ino=1076 scontext=system_u:object_r:unlabeled_t:s0 tcontext=system_u:object_r:cgroup_t:s0 tclass=filesystem permissive=1 srawcon="system_u:object_r:dhcpd_unit_file_t:s0"
cgroup: Unknown subsys name ''
SELinux: security_context_str_to_sid (system_u) failed with errno=-22