======================================================
WARNING: possible circular locking dependency detected
6.3.0-rc1-next-20230308 #1 Not tainted
------------------------------------------------------
syz-executor.4/5830 is trying to acquire lock:
ffff888010186170 (&journal->j_barrier){+.+.}-{3:3}, at: jbd2_journal_lock_updates+0x162/0x310

but task is already holding lock:
ffff888010184b90 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_change_inode_journal_flag+0x17f/0x550

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&sbi->s_writepages_rwsem){++++}-{0:0}:
       percpu_down_write+0x51/0x330
       ext4_ind_migrate+0x23b/0x840
       ext4_fileattr_set+0x1521/0x19f0
       vfs_fileattr_set+0x7a2/0xbd0
       do_vfs_ioctl+0xfc1/0x1690
       __x64_sys_ioctl+0x110/0x210
       do_syscall_64+0x3f/0x90
       entry_SYSCALL_64_after_hwframe+0x72/0xdc

-> #2 (&sb->s_type->i_mutex_key#6){++++}-{3:3}:
       down_read+0x3d/0x50
       ext4_bmap+0x52/0x470
       bmap+0xb0/0x130
       jbd2_journal_bmap+0xac/0x1d0
       jbd2_journal_flush+0x87f/0xc90
       __ext4_ioctl+0x9fd/0x4330
       __x64_sys_ioctl+0x19e/0x210
       do_syscall_64+0x3f/0x90
       entry_SYSCALL_64_after_hwframe+0x72/0xdc

-> #1 (&journal->j_checkpoint_mutex){+.+.}-{3:3}:
       mutex_lock_io_nested+0x149/0x1300
       jbd2_journal_flush+0x19e/0xc90
       __ext4_ioctl+0x9fd/0x4330
       __x64_sys_ioctl+0x19e/0x210
       do_syscall_64+0x3f/0x90
       entry_SYSCALL_64_after_hwframe+0x72/0xdc

-> #0 (&journal->j_barrier){+.+.}-{3:3}:
       __lock_acquire+0x2d56/0x6380
       lock_acquire.part.0+0xea/0x320
       __mutex_lock+0x133/0x14a0
       jbd2_journal_lock_updates+0x162/0x310
       ext4_change_inode_journal_flag+0x187/0x550
       ext4_fileattr_set+0x14fa/0x19f0
       vfs_fileattr_set+0x7a2/0xbd0
       do_vfs_ioctl+0xfc1/0x1690
       __x64_sys_ioctl+0x110/0x210
       do_syscall_64+0x3f/0x90
       entry_SYSCALL_64_after_hwframe+0x72/0xdc

other info that might help us debug this:

Chain exists of:
  &journal->j_barrier --> &sb->s_type->i_mutex_key#6 --> &sbi->s_writepages_rwsem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&sbi->s_writepages_rwsem);
                               lock(&sb->s_type->i_mutex_key#6);
                               lock(&sbi->s_writepages_rwsem);
  lock(&journal->j_barrier);

 *** DEADLOCK ***

4 locks held by syz-executor.4/5830:
 #0: ffff888010182438 (sb_writers#3){.+.+}-{0:0}, at: do_vfs_ioctl+0xf86/0x1690
 #1: ffff88801bd83fa0 (&sb->s_type->i_mutex_key#6){++++}-{3:3}, at: vfs_fileattr_set+0x14c/0xbd0
 #2: ffff88801bd84140 (mapping.invalidate_lock){++++}-{3:3}, at: ext4_change_inode_journal_flag+0x126/0x550
 #3: ffff888010184b90 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_change_inode_journal_flag+0x17f/0x550

stack backtrace:
CPU: 0 PID: 5830 Comm: syz-executor.4 Not tainted 6.3.0-rc1-next-20230308 #1
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014
Call Trace:
 <TASK>
 dump_stack_lvl+0x91/0xf0
 check_noncircular+0x263/0x2e0
 __lock_acquire+0x2d56/0x6380
 lock_acquire.part.0+0xea/0x320
 __mutex_lock+0x133/0x14a0
 jbd2_journal_lock_updates+0x162/0x310
 ext4_change_inode_journal_flag+0x187/0x550
 ext4_fileattr_set+0x14fa/0x19f0
 vfs_fileattr_set+0x7a2/0xbd0
 do_vfs_ioctl+0xfc1/0x1690
 __x64_sys_ioctl+0x110/0x210
 do_syscall_64+0x3f/0x90
 entry_SYSCALL_64_after_hwframe+0x72/0xdc
RIP: 0033:0x7f9dcf182b19
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f9dcc6f8188 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007f9dcf295f60 RCX: 00007f9dcf182b19
RDX: 0000000020000040 RSI: 0000000040086602 RDI: 0000000000000003
RBP: 00007f9dcf1dcf6d R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ffc6a81508f R14: 00007f9dcc6f8300 R15: 0000000000022000
 </TASK>
FAULT_INJECTION: forcing a failure.
name failslab, interval 1, probability 0, space 0, times 0
CPU: 1 PID: 5827 Comm: syz-executor.6 Not tainted 6.3.0-rc1-next-20230308 #1
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014
Call Trace:
 <TASK>
 dump_stack_lvl+0xc1/0xf0
 should_fail_ex+0x4b4/0x5b0
 should_failslab+0x9/0x20
 kmem_cache_alloc+0x5a/0x320
 ext4_init_io_end+0x27/0x180
 ext4_do_writepages+0x933/0x33f0
 ext4_writepages+0x274/0x5e0
 do_writepages+0x1ad/0x650
 filemap_fdatawrite_wbc+0x14b/0x1b0
 __filemap_fdatawrite_range+0xba/0x100
 file_write_and_wait_range+0xd2/0x140
 ext4_sync_file+0x221/0x1010
 vfs_fsync_range+0x141/0x230
 ext4_buffered_write_iter+0x37d/0x460
 ext4_file_write_iter+0x3ff/0x1950
 do_iter_readv_writev+0x211/0x3c0
 do_iter_write+0x18b/0x700
 vfs_iter_write+0x74/0xb0
 iter_file_splice_write+0x73f/0xcb0
 direct_splice_actor+0x113/0x180
 splice_direct_to_actor+0x33a/0x8c0
 do_splice_direct+0x1bc/0x290
 do_sendfile+0xb1d/0x12b0
 __x64_sys_sendfile64+0x1d5/0x210
 do_syscall_64+0x3f/0x90
 entry_SYSCALL_64_after_hwframe+0x72/0xdc
RIP: 0033:0x7f2dabc67b19
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f2da91dd188 EFLAGS: 00000246 ORIG_RAX: 0000000000000028
RAX: ffffffffffffffda RBX: 00007f2dabd7af60 RCX: 00007f2dabc67b19
RDX: 0000000000000000 RSI: 0000000000000005 RDI: 0000000000000004
RBP: 00007f2da91dd1d0 R08: 0000000000000000 R09: 0000000000000000
R10: 000000010000027f R11: 0000000000000246 R12: 0000000000000002
R13: 00007ffe270c037f R14: 00007f2da91dd300 R15: 0000000000022000
 </TASK>
FAULT_INJECTION: forcing a failure.
name failslab, interval 1, probability 0, space 0, times 0
CPU: 0 PID: 5874 Comm: syz-executor.6 Not tainted 6.3.0-rc1-next-20230308 #1
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014
Call Trace:
 <TASK>
 dump_stack_lvl+0xc1/0xf0
 should_fail_ex+0x4b4/0x5b0
 should_failslab+0x9/0x20
 kmem_cache_alloc+0x5a/0x320
 ext4_init_io_end+0x27/0x180
 ext4_do_writepages+0xa35/0x33f0
 ext4_writepages+0x274/0x5e0
 do_writepages+0x1ad/0x650
 filemap_fdatawrite_wbc+0x14b/0x1b0
 __filemap_fdatawrite_range+0xba/0x100
 file_write_and_wait_range+0xd2/0x140
 ext4_sync_file+0x221/0x1010
 vfs_fsync_range+0x141/0x230
 ext4_buffered_write_iter+0x37d/0x460
 ext4_file_write_iter+0x3ff/0x1950
 do_iter_readv_writev+0x211/0x3c0
 do_iter_write+0x18b/0x700
 vfs_iter_write+0x74/0xb0
 iter_file_splice_write+0x73f/0xcb0
 direct_splice_actor+0x113/0x180
 splice_direct_to_actor+0x33a/0x8c0
 do_splice_direct+0x1bc/0x290
 do_sendfile+0xb1d/0x12b0
 __x64_sys_sendfile64+0x1d5/0x210
 do_syscall_64+0x3f/0x90
 entry_SYSCALL_64_after_hwframe+0x72/0xdc
RIP: 0033:0x7f2dabc67b19
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f2da91dd188 EFLAGS: 00000246 ORIG_RAX: 0000000000000028
RAX: ffffffffffffffda RBX: 00007f2dabd7af60 RCX: 00007f2dabc67b19
RDX: 0000000000000000 RSI: 0000000000000005 RDI: 0000000000000004
RBP: 00007f2da91dd1d0 R08: 0000000000000000 R09: 0000000000000000
R10: 000000010000027f R11: 0000000000000246 R12: 0000000000000002
R13: 00007ffe270c037f R14: 00007f2da91dd300 R15: 0000000000022000
 </TASK>