====================================================== WARNING: possible circular locking dependency detected 6.1.0-rc1-next-20221019 #1 Not tainted ------------------------------------------------------ syz-executor.0/34185 is trying to acquire lock: ffff8880104c4170 (&journal->j_barrier){+.+.}-{3:3}, at: jbd2_journal_lock_updates+0x15e/0x320 but task is already holding lock: ffff8880104c2b90 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_change_inode_journal_flag+0x177/0x540 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #3 (&sbi->s_writepages_rwsem){++++}-{0:0}: percpu_down_write+0x4d/0x360 ext4_ind_migrate+0x237/0x840 ext4_fileattr_set+0x144e/0x18d0 vfs_fileattr_set+0x77c/0xb90 do_vfs_ioctl+0xfc1/0x1620 __x64_sys_ioctl+0x10c/0x220 do_syscall_64+0x3b/0xa0 entry_SYSCALL_64_after_hwframe+0x72/0xdc -> #2 (&sb->s_type->i_mutex_key#6){++++}-{3:3}: down_read+0x98/0x460 ext4_bmap+0x4e/0x480 bmap+0xac/0x130 jbd2_journal_bmap+0xa8/0x190 jbd2_journal_flush+0x853/0xc10 __ext4_ioctl+0x9e9/0x40b0 __x64_sys_ioctl+0x19a/0x220 do_syscall_64+0x3b/0xa0 entry_SYSCALL_64_after_hwframe+0x72/0xdc -> #1 (&journal->j_checkpoint_mutex){+.+.}-{3:3}: mutex_lock_io_nested+0x148/0x1320 jbd2_journal_flush+0x19a/0xc10 __ext4_ioctl+0x9e9/0x40b0 __x64_sys_ioctl+0x19a/0x220 do_syscall_64+0x3b/0xa0 entry_SYSCALL_64_after_hwframe+0x72/0xdc -> #0 (&journal->j_barrier){+.+.}-{3:3}: __lock_acquire+0x2a02/0x5e80 lock_acquire+0x1a2/0x540 __mutex_lock+0x136/0x14e0 jbd2_journal_lock_updates+0x15e/0x320 ext4_change_inode_journal_flag+0x17f/0x540 ext4_fileattr_set+0x1427/0x18d0 vfs_fileattr_set+0x77c/0xb90 do_vfs_ioctl+0xfc1/0x1620 __x64_sys_ioctl+0x10c/0x220 do_syscall_64+0x3b/0xa0 entry_SYSCALL_64_after_hwframe+0x72/0xdc other info that might help us debug this: Chain exists of: &journal->j_barrier --> &sb->s_type->i_mutex_key#6 --> &sbi->s_writepages_rwsem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&sbi->s_writepages_rwsem); lock(&sb->s_type->i_mutex_key#6); lock(&sbi->s_writepages_rwsem); lock(&journal->j_barrier); *** DEADLOCK *** 4 locks held by syz-executor.0/34185: #0: ffff8880104c0438 (sb_writers#3){.+.+}-{0:0}, at: do_vfs_ioctl+0xf86/0x1620 #1: ffff888044873fa0 (&sb->s_type->i_mutex_key#6){++++}-{3:3}, at: vfs_fileattr_set+0x148/0xb90 #2: ffff888044874140 (mapping.invalidate_lock){++++}-{3:3}, at: ext4_change_inode_journal_flag+0x11e/0x540 #3: ffff8880104c2b90 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_change_inode_journal_flag+0x177/0x540 stack backtrace: CPU: 0 PID: 34185 Comm: syz-executor.0 Not tainted 6.1.0-rc1-next-20221019 #1 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014 Call Trace: dump_stack_lvl+0x8b/0xc3 check_noncircular+0x263/0x2f0 __lock_acquire+0x2a02/0x5e80 lock_acquire+0x1a2/0x540 __mutex_lock+0x136/0x14e0 jbd2_journal_lock_updates+0x15e/0x320 ext4_change_inode_journal_flag+0x17f/0x540 ext4_fileattr_set+0x1427/0x18d0 vfs_fileattr_set+0x77c/0xb90 do_vfs_ioctl+0xfc1/0x1620 __x64_sys_ioctl+0x10c/0x220 do_syscall_64+0x3b/0xa0 entry_SYSCALL_64_after_hwframe+0x72/0xdc RIP: 0033:0x7fb093204b19 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fb09077a188 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 00007fb093317f60 RCX: 00007fb093204b19 RDX: 0000000020000080 RSI: 0000000040086602 RDI: 0000000000000003 RBP: 00007fb09325ef6d R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007fff31cfeddf R14: 00007fb09077a300 R15: 0000000000022000 tmpfs: Bad value for 'mpol' tmpfs: Bad value for 'mpol' tmpfs: Bad value for 'mpol' tmpfs: Bad value for 'mpol'