======================================================
WARNING: possible circular locking dependency detected
5.19.0-next-20220811 #1 Not tainted
------------------------------------------------------
syz-executor.1/22861 is trying to acquire lock:
ffff88800fe58170 (&journal->j_barrier){+.+.}-{3:3}, at: jbd2_journal_lock_updates+0x15e/0x310
but task is already holding lock:
ffff88800fe86bd0 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_change_inode_journal_flag+0x177/0x530
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #3 (&sbi->s_writepages_rwsem){++++}-{0:0}:
ext4_writepages+0x1d2/0x3690
do_writepages+0x1b0/0x6a0
filemap_fdatawrite_wbc+0x147/0x1b0
__filemap_fdatawrite_range+0xb6/0x100
filemap_write_and_wait_range+0x89/0x110
__iomap_dio_rw+0x5ed/0x1bd0
iomap_dio_rw+0x3c/0xa0
ext4_file_write_iter+0xa96/0x1820
do_iter_readv_writev+0x211/0x3c0
do_iter_write+0x18b/0x700
vfs_iter_write+0x70/0xa0
iter_file_splice_write+0x73a/0xca0
direct_splice_actor+0x10f/0x170
splice_direct_to_actor+0x336/0x8c0
do_splice_direct+0x1b8/0x290
do_sendfile+0xb1d/0x1280
__x64_sys_sendfile64+0x1d1/0x210
do_syscall_64+0x3b/0x90
entry_SYSCALL_64_after_hwframe+0x63/0xcd
-> #2 (&sb->s_type->i_mutex_key#6){++++}-{3:3}:
down_read+0x98/0x450
ext4_bmap+0x4e/0x470
bmap+0xac/0x120
jbd2_journal_bmap+0xa8/0x180
jbd2_journal_flush+0x853/0xc00
__ext4_ioctl+0x9e9/0x4090
__x64_sys_ioctl+0x19a/0x210
do_syscall_64+0x3b/0x90
entry_SYSCALL_64_after_hwframe+0x63/0xcd
-> #1 (&journal->j_checkpoint_mutex){+.+.}-{3:3}:
mutex_lock_io_nested+0x148/0x1310
jbd2_journal_flush+0x19a/0xc00
__ext4_ioctl+0x9e9/0x4090
__x64_sys_ioctl+0x19a/0x210
do_syscall_64+0x3b/0x90
entry_SYSCALL_64_after_hwframe+0x63/0xcd
-> #0 (&journal->j_barrier){+.+.}-{3:3}:
__lock_acquire+0x2a02/0x5e70
lock_acquire+0x1a2/0x530
__mutex_lock+0x136/0x14d0
jbd2_journal_lock_updates+0x15e/0x310
ext4_change_inode_journal_flag+0x17f/0x530
ext4_fileattr_set+0x140d/0x18a0
vfs_fileattr_set+0x77c/0xb80
do_vfs_ioctl+0xfc2/0x1610
__x64_sys_ioctl+0x10c/0x210
do_syscall_64+0x3b/0x90
entry_SYSCALL_64_after_hwframe+0x63/0xcd
other info that might help us debug this:
Chain exists of:
&journal->j_barrier --> &sb->s_type->i_mutex_key#6 --> &sbi->s_writepages_rwsem
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&sbi->s_writepages_rwsem);
lock(&sb->s_type->i_mutex_key#6);
lock(&sbi->s_writepages_rwsem);
lock(&journal->j_barrier);
*** DEADLOCK ***
4 locks held by syz-executor.1/22861:
#0: ffff88800fe84438 (sb_writers#3){.+.+}-{0:0}, at: do_vfs_ioctl+0xf87/0x1610
#1: ffff88801d6f17e0 (&sb->s_type->i_mutex_key#6){++++}-{3:3}, at: vfs_fileattr_set+0x148/0xb80
#2: ffff88801d6f1980 (mapping.invalidate_lock){++++}-{3:3}, at: ext4_change_inode_journal_flag+0x11e/0x530
#3: ffff88800fe86bd0 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_change_inode_journal_flag+0x177/0x530
stack backtrace:
CPU: 1 PID: 22861 Comm: syz-executor.1 Not tainted 5.19.0-next-20220811 #1
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.14.0-0-g155821a1990b-prebuilt.qemu.org 04/01/2014
Call Trace:
dump_stack_lvl+0x8b/0xb3
check_noncircular+0x263/0x2e0
__lock_acquire+0x2a02/0x5e70
lock_acquire+0x1a2/0x530
__mutex_lock+0x136/0x14d0
jbd2_journal_lock_updates+0x15e/0x310
ext4_change_inode_journal_flag+0x17f/0x530
ext4_fileattr_set+0x140d/0x18a0
vfs_fileattr_set+0x77c/0xb80
do_vfs_ioctl+0xfc2/0x1610
__x64_sys_ioctl+0x10c/0x210
do_syscall_64+0x3b/0x90
entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f22d2cb2b19
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f22d0228188 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007f22d2dc5f60 RCX: 00007f22d2cb2b19
RDX: 0000000020000080 RSI: 0000000040086602 RDI: 0000000000000006
RBP: 00007f22d2d0cf6d R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007fff4ad92c2f R14: 00007f22d0228300 R15: 0000000000022000
FAULT_INJECTION: forcing a failure.
name fail_usercopy, interval 1, probability 0, space 0, times 0
CPU: 0 PID: 22865 Comm: syz-executor.3 Not tainted 5.19.0-next-20220811 #1
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.14.0-0-g155821a1990b-prebuilt.qemu.org 04/01/2014
Call Trace:
dump_stack_lvl+0x8b/0xb3
should_fail.cold+0x5/0xa
_copy_from_user+0x2a/0x170
copy_msghdr_from_user+0x89/0x150
___sys_sendmsg+0xdd/0x1b0
__sys_sendmmsg+0x18b/0x460
__x64_sys_sendmmsg+0x99/0x100
do_syscall_64+0x3b/0x90
entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f1f0562eb19
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f1f02ba4188 EFLAGS: 00000246 ORIG_RAX: 0000000000000133
RAX: ffffffffffffffda RBX: 00007f1f05741f60 RCX: 00007f1f0562eb19
RDX: 0000000004000101 RSI: 0000000020002880 RDI: 0000000000000005
RBP: 00007f1f02ba41d0 R08: 0000000000000000 R09: 0000000000000000
R10: 000000007ffffff7 R11: 0000000000000246 R12: 0000000000000002
R13: 00007fffc5d756ef R14: 00007f1f02ba4300 R15: 0000000000022000