warning: checkpointing journal with EXT4_IOC_CHECKPOINT_FLAG_ZEROOUT can be slow
======================================================
WARNING: possible circular locking dependency detected
5.19.0-next-20220811 #1 Not tainted
------------------------------------------------------
syz-executor.5/4946 is trying to acquire lock:
ffff88800ff0e170 (&journal->j_barrier){+.+.}-{3:3}, at: jbd2_journal_lock_updates+0x15e/0x310
but task is already holding lock:
ffff88800ff0cbd0 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_change_inode_journal_flag+0x177/0x530
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #3 (&sbi->s_writepages_rwsem){++++}-{0:0}:
ext4_writepages+0x1d2/0x3690
do_writepages+0x1b0/0x6a0
filemap_fdatawrite_wbc+0x147/0x1b0
__filemap_fdatawrite_range+0xb6/0x100
filemap_write_and_wait_range+0x89/0x110
__iomap_dio_rw+0x5ed/0x1bd0
iomap_dio_rw+0x3c/0xa0
ext4_file_read_iter+0x268/0x400
generic_file_splice_read+0x187/0x4d0
do_splice_to+0x1bc/0x240
splice_direct_to_actor+0x2ac/0x8c0
do_splice_direct+0x1b8/0x290
do_sendfile+0xb1d/0x1280
__x64_sys_sendfile64+0x1d1/0x210
do_syscall_64+0x3b/0x90
entry_SYSCALL_64_after_hwframe+0x63/0xcd
-> #2 (&sb->s_type->i_mutex_key#6){++++}-{3:3}:
down_read+0x98/0x450
ext4_bmap+0x4e/0x470
bmap+0xac/0x120
jbd2_journal_bmap+0xa8/0x180
jbd2_journal_flush+0x853/0xc00
__ext4_ioctl+0x9e9/0x4090
__x64_sys_ioctl+0x19a/0x210
do_syscall_64+0x3b/0x90
entry_SYSCALL_64_after_hwframe+0x63/0xcd
-> #1 (&journal->j_checkpoint_mutex){+.+.}-{3:3}:
mutex_lock_io_nested+0x148/0x1310
jbd2_journal_flush+0x19a/0xc00
__ext4_ioctl+0x9e9/0x4090
__x64_sys_ioctl+0x19a/0x210
do_syscall_64+0x3b/0x90
entry_SYSCALL_64_after_hwframe+0x63/0xcd
-> #0 (&journal->j_barrier){+.+.}-{3:3}:
__lock_acquire+0x2a02/0x5e70
lock_acquire+0x1a2/0x530
__mutex_lock+0x136/0x14d0
jbd2_journal_lock_updates+0x15e/0x310
ext4_change_inode_journal_flag+0x17f/0x530
ext4_fileattr_set+0x140d/0x18a0
vfs_fileattr_set+0x77c/0xb80
do_vfs_ioctl+0xfc2/0x1610
__x64_sys_ioctl+0x10c/0x210
do_syscall_64+0x3b/0x90
entry_SYSCALL_64_after_hwframe+0x63/0xcd
other info that might help us debug this:
Chain exists of:
&journal->j_barrier --> &sb->s_type->i_mutex_key#6 --> &sbi->s_writepages_rwsem
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&sbi->s_writepages_rwsem);
lock(&sb->s_type->i_mutex_key#6);
lock(&sbi->s_writepages_rwsem);
lock(&journal->j_barrier);
*** DEADLOCK ***
4 locks held by syz-executor.5/4946:
#0: ffff88800ff0a438 (sb_writers#3){.+.+}-{0:0}, at: do_vfs_ioctl+0xf87/0x1610
#1: ffff88801d1db5b0 (&sb->s_type->i_mutex_key#6){++++}-{3:3}, at: vfs_fileattr_set+0x148/0xb80
#2: ffff88801d1db750 (mapping.invalidate_lock){++++}-{3:3}, at: ext4_change_inode_journal_flag+0x11e/0x530
#3: ffff88800ff0cbd0 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_change_inode_journal_flag+0x177/0x530
stack backtrace:
CPU: 0 PID: 4946 Comm: syz-executor.5 Not tainted 5.19.0-next-20220811 #1
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.14.0-0-g155821a1990b-prebuilt.qemu.org 04/01/2014
Call Trace:
dump_stack_lvl+0x8b/0xb3
check_noncircular+0x263/0x2e0
__lock_acquire+0x2a02/0x5e70
lock_acquire+0x1a2/0x530
__mutex_lock+0x136/0x14d0
jbd2_journal_lock_updates+0x15e/0x310
ext4_change_inode_journal_flag+0x17f/0x530
ext4_fileattr_set+0x140d/0x18a0
vfs_fileattr_set+0x77c/0xb80
do_vfs_ioctl+0xfc2/0x1610
__x64_sys_ioctl+0x10c/0x210
do_syscall_64+0x3b/0x90
entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7faecb747b19
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007faec8cbd188 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007faecb85af60 RCX: 00007faecb747b19
RDX: 0000000020000080 RSI: 0000000040086602 RDI: 0000000000000005
RBP: 00007faecb7a1f6d R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007fff9757fcdf R14: 00007faec8cbd300 R15: 0000000000022000
nfs4: Bad value for 'source'
warning: checkpointing journal with EXT4_IOC_CHECKPOINT_FLAG_ZEROOUT can be slow
warning: checkpointing journal with EXT4_IOC_CHECKPOINT_FLAG_ZEROOUT can be slow
warning: checkpointing journal with EXT4_IOC_CHECKPOINT_FLAG_ZEROOUT can be slow
semctl(GETNCNT/GETZCNT) is since 3.16 Single Unix Specification compliant.
The task syz-executor.7 (4990) triggered the difference, watch for misbehavior.
FAULT_INJECTION: forcing a failure.
name fail_usercopy, interval 1, probability 0, space 0, times 1
CPU: 1 PID: 4991 Comm: syz-executor.3 Not tainted 5.19.0-next-20220811 #1
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.14.0-0-g155821a1990b-prebuilt.qemu.org 04/01/2014
Call Trace:
dump_stack_lvl+0x8b/0xb3
should_fail.cold+0x5/0xa
_copy_to_user+0x2a/0x140
simple_read_from_buffer+0xcc/0x160
proc_fail_nth_read+0x198/0x230
vfs_read+0x253/0x930
ksys_read+0x127/0x250
do_syscall_64+0x3b/0x90
entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f4a1696269c
Code: ec 28 48 89 54 24 18 48 89 74 24 10 89 7c 24 08 e8 f9 fc ff ff 48 8b 54 24 18 48 8b 74 24 10 41 89 c0 8b 7c 24 08 31 c0 0f 05 <48> 3d 00 f0 ff ff 77 34 44 89 c7 48 89 44 24 08 e8 2f fd ff ff 48
RSP: 002b:00007f4a13f25170 EFLAGS: 00000246 ORIG_RAX: 0000000000000000
RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f4a1696269c
RDX: 000000000000000f RSI: 00007f4a13f251e0 RDI: 0000000000000003
RBP: 00007f4a13f251d0 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000001
R13: 00007ffd03b89bef R14: 00007f4a13f25300 R15: 0000000000022000
warning: checkpointing journal with EXT4_IOC_CHECKPOINT_FLAG_ZEROOUT can be slow
netlink: 2552 bytes leftover after parsing attributes in process `syz-executor.1'.
warning: checkpointing journal with EXT4_IOC_CHECKPOINT_FLAG_ZEROOUT can be slow
netlink: 2552 bytes leftover after parsing attributes in process `syz-executor.1'.