RBP: 00007fef3984d1d0 R08: 0000000000000000 R09: 0000000000000000
R10: 000000007ffffff9 R11: 0000000000000246 R12: 0000000000000002
R13: 00007ffdf3687f4f R14: 00007fef3984d300 R15: 0000000000022000
======================================================
WARNING: possible circular locking dependency detected
5.10.199 #1 Not tainted
------------------------------------------------------
syz-executor.5/16714 is trying to acquire lock:
ffff888016e68ae8 ((work_completion)(&hdev->tx_work)){+.+.}-{0:0}, at: __flush_work+0xdd/0xa90 kernel/workqueue.c:3050

but task is already holding lock:
ffff888016e68f40 (&hdev->req_lock){+.+.}-{3:3}, at: hci_dev_do_close+0xef/0x1240 net/bluetooth/hci_core.c:1734

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&hdev->req_lock){+.+.}-{3:3}:
       __mutex_lock_common kernel/locking/mutex.c:968 [inline]
       __mutex_lock+0x13d/0x10b0 kernel/locking/mutex.c:1109
       hci_dev_do_close+0xef/0x1240 net/bluetooth/hci_core.c:1734
       hci_rfkill_set_block+0x166/0x1a0 net/bluetooth/hci_core.c:2223
       rfkill_set_block+0x1fd/0x540 net/rfkill/core.c:341
       rfkill_fop_write+0x253/0x4b0 net/rfkill/core.c:1240
       vfs_write+0x29a/0xa70 fs/read_write.c:603
       ksys_write+0x1f6/0x260 fs/read_write.c:658
       do_syscall_64+0x33/0x40 arch/x86/entry/common.c:46
       entry_SYSCALL_64_after_hwframe+0x62/0xc7

-> #2 (rfkill_global_mutex){+.+.}-{3:3}:
       __mutex_lock_common kernel/locking/mutex.c:968 [inline]
       __mutex_lock+0x13d/0x10b0 kernel/locking/mutex.c:1109
       rfkill_register+0x36/0xa10 net/rfkill/core.c:1016
       hci_register_dev+0x42e/0xc00 net/bluetooth/hci_core.c:3773
       __vhci_create_device+0x2c8/0x5c0 drivers/bluetooth/hci_vhci.c:129
       vhci_create_device drivers/bluetooth/hci_vhci.c:153 [inline]
       vhci_open_timeout+0x38/0x50 drivers/bluetooth/hci_vhci.c:310
       process_one_work+0x9a9/0x14b0 kernel/workqueue.c:2282
       worker_thread+0x61d/0x1310 kernel/workqueue.c:2428
       kthread+0x38f/0x470 kernel/kthread.c:313
       ret_from_fork+0x22/0x30 arch/x86/entry/entry_64.S:299

-> #1 (&data->open_mutex){+.+.}-{3:3}:
       __mutex_lock_common kernel/locking/mutex.c:968 [inline]
       __mutex_lock+0x13d/0x10b0 kernel/locking/mutex.c:1109
       vhci_send_frame+0x63/0xa0 drivers/bluetooth/hci_vhci.c:71
       hci_send_frame+0x1b9/0x320 net/bluetooth/hci_core.c:4060
       hci_sched_acl_pkt net/bluetooth/hci_core.c:4585 [inline]
       hci_sched_acl net/bluetooth/hci_core.c:4670 [inline]
       hci_tx_work+0x10af/0x1660 net/bluetooth/hci_core.c:4741
       process_one_work+0x9a9/0x14b0 kernel/workqueue.c:2282
       worker_thread+0x61d/0x1310 kernel/workqueue.c:2428
       kthread+0x38f/0x470 kernel/kthread.c:313
       ret_from_fork+0x22/0x30 arch/x86/entry/entry_64.S:299

-> #0 ((work_completion)(&hdev->tx_work)){+.+.}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:2988 [inline]
       check_prevs_add kernel/locking/lockdep.c:3113 [inline]
       validate_chain kernel/locking/lockdep.c:3728 [inline]
       __lock_acquire+0x29e7/0x5b00 kernel/locking/lockdep.c:4954
       lock_acquire kernel/locking/lockdep.c:5565 [inline]
       lock_acquire+0x197/0x470 kernel/locking/lockdep.c:5530
       __flush_work+0x105/0xa90 kernel/workqueue.c:3053
       hci_dev_do_close+0x131/0x1240 net/bluetooth/hci_core.c:1745
       hci_rfkill_set_block+0x166/0x1a0 net/bluetooth/hci_core.c:2223
       rfkill_set_block+0x1fd/0x540 net/rfkill/core.c:341
       rfkill_fop_write+0x253/0x4b0 net/rfkill/core.c:1240
       vfs_write+0x29a/0xa70 fs/read_write.c:603
       ksys_write+0x1f6/0x260 fs/read_write.c:658
       do_syscall_64+0x33/0x40 arch/x86/entry/common.c:46
       entry_SYSCALL_64_after_hwframe+0x62/0xc7

other info that might help us debug this:

Chain exists of:
  (work_completion)(&hdev->tx_work) --> rfkill_global_mutex --> &hdev->req_lock

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&hdev->req_lock);
                               lock(rfkill_global_mutex);
                               lock(&hdev->req_lock);
  lock((work_completion)(&hdev->tx_work));

 *** DEADLOCK ***

2 locks held by syz-executor.5/16714:
 #0: ffffffff85619468 (rfkill_global_mutex){+.+.}-{3:3}, at: rfkill_fop_write+0xff/0x4b0 net/rfkill/core.c:1232
 #1: ffff888016e68f40 (&hdev->req_lock){+.+.}-{3:3}, at: hci_dev_do_close+0xef/0x1240 net/bluetooth/hci_core.c:1734

stack backtrace:
CPU: 1 PID: 16714 Comm: syz-executor.5 Not tainted 5.10.199 #1
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x107/0x167 lib/dump_stack.c:118
 check_noncircular+0x263/0x2e0 kernel/locking/lockdep.c:2123
 check_prev_add kernel/locking/lockdep.c:2988 [inline]
 check_prevs_add kernel/locking/lockdep.c:3113 [inline]
 validate_chain kernel/locking/lockdep.c:3728 [inline]
 __lock_acquire+0x29e7/0x5b00 kernel/locking/lockdep.c:4954
 lock_acquire kernel/locking/lockdep.c:5565 [inline]
 lock_acquire+0x197/0x470 kernel/locking/lockdep.c:5530
 __flush_work+0x105/0xa90 kernel/workqueue.c:3053
 hci_dev_do_close+0x131/0x1240 net/bluetooth/hci_core.c:1745
 hci_rfkill_set_block+0x166/0x1a0 net/bluetooth/hci_core.c:2223
 rfkill_set_block+0x1fd/0x540 net/rfkill/core.c:341
 rfkill_fop_write+0x253/0x4b0 net/rfkill/core.c:1240
 vfs_write+0x29a/0xa70 fs/read_write.c:603
 ksys_write+0x1f6/0x260 fs/read_write.c:658
 do_syscall_64+0x33/0x40 arch/x86/entry/common.c:46
 entry_SYSCALL_64_after_hwframe+0x62/0xc7
RIP: 0033:0x7fe128132b19
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fe1256a8188 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 00007fe128245f60 RCX: 00007fe128132b19
RDX: 0000000000000008 RSI: 00000000200000c0 RDI: 0000000000000006
RBP: 00007fe12818cf6d R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ffd1876ecdf R14: 00007fe1256a8300 R15: 0000000000022000
FAULT_INJECTION: forcing a failure.
name failslab, interval 1, probability 0, space 0, times 0
CPU: 1 PID: 16700 Comm: syz-executor.3 Not tainted 5.10.199 #1
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x107/0x167 lib/dump_stack.c:118
 fail_dump lib/fault-inject.c:52 [inline]
 should_fail.cold+0x5/0xa lib/fault-inject.c:146
 should_failslab+0x5/0x20 mm/slab_common.c:1193
 slab_pre_alloc_hook mm/slab.h:515 [inline]
 slab_alloc_node mm/slub.c:2821 [inline]
 slab_alloc mm/slub.c:2904 [inline]
 kmem_cache_alloc+0x5b/0x310 mm/slub.c:2909
 mem_pool_alloc mm/kmemleak.c:423 [inline]
 create_object.isra.0+0x3a/0xa20 mm/kmemleak.c:578
 kmemleak_alloc_recursive include/linux/kmemleak.h:43 [inline]
 slab_post_alloc_hook mm/slab.h:534 [inline]
 slab_alloc_node mm/slub.c:2896 [inline]
 slab_alloc mm/slub.c:2904 [inline]
 __kmalloc+0x16e/0x390 mm/slub.c:3967
 kmalloc_array include/linux/slab.h:592 [inline]
 __blkdev_direct_IO_simple+0x222/0x930 fs/block_dev.c:256
 blkdev_direct_IO+0xb35/0x12a0 fs/block_dev.c:513
 generic_file_direct_write+0x20e/0x560 mm/filemap.c:3235
 __generic_file_write_iter+0x235/0x5d0 mm/filemap.c:3422
 blkdev_write_iter+0x298/0x550 fs/block_dev.c:1934
 call_write_iter include/linux/fs.h:1919 [inline]
 do_iter_readv_writev+0x476/0x750 fs/read_write.c:740
 do_iter_write+0x191/0x670 fs/read_write.c:866
 vfs_iter_write+0x70/0xa0 fs/read_write.c:907
 iter_file_splice_write+0x762/0xc30 fs/splice.c:686
 do_splice_from fs/splice.c:764 [inline]
 direct_splice_actor+0x10f/0x170 fs/splice.c:933
 splice_direct_to_actor+0x387/0x980 fs/splice.c:888
 do_splice_direct+0x1c4/0x290 fs/splice.c:976
 do_sendfile+0x553/0x1090 fs/read_write.c:1257
 __do_sys_sendfile64 fs/read_write.c:1318 [inline]
 __se_sys_sendfile64 fs/read_write.c:1304 [inline]
 __x64_sys_sendfile64+0x1d1/0x210 fs/read_write.c:1304
 do_syscall_64+0x33/0x40 arch/x86/entry/common.c:46
 entry_SYSCALL_64_after_hwframe+0x62/0xc7
RIP: 0033:0x7f936a2a2b19
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f9367818188 EFLAGS: 00000246 ORIG_RAX: 0000000000000028
RAX: ffffffffffffffda RBX: 00007f936a3b5f60 RCX: 00007f936a2a2b19
RDX: 0000000000000000 RSI: 0000000000000004 RDI: 0000000000000006
RBP: 00007f93678181d0 R08: 0000000000000000 R09: 0000000000000000
R10: 000000007ffffff9 R11: 0000000000000246 R12: 0000000000000002
R13: 00007ffe1c7d546f R14: 00007f9367818300 R15: 0000000000022000
FAULT_INJECTION: forcing a failure.
name failslab, interval 1, probability 0, space 0, times 0
CPU: 0 PID: 16842 Comm: syz-executor.1 Not tainted 5.10.199 #1
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x107/0x167 lib/dump_stack.c:118
 fail_dump lib/fault-inject.c:52 [inline]
 should_fail.cold+0x5/0xa lib/fault-inject.c:146
 should_failslab+0x5/0x20 mm/slab_common.c:1193
 slab_pre_alloc_hook mm/slab.h:515 [inline]
 slab_alloc_node mm/slub.c:2821 [inline]
 slab_alloc mm/slub.c:2904 [inline]
 kmem_cache_alloc+0x5b/0x310 mm/slub.c:2909
 mem_pool_alloc mm/kmemleak.c:423 [inline]
 create_object.isra.0+0x3a/0xa20 mm/kmemleak.c:578
 kmemleak_alloc_recursive include/linux/kmemleak.h:43 [inline]
 slab_post_alloc_hook mm/slab.h:534 [inline]
 slab_alloc_node mm/slub.c:2896 [inline]
 slab_alloc mm/slub.c:2904 [inline]
 kmem_cache_alloc+0x159/0x310 mm/slub.c:2909
 mempool_alloc+0x148/0x360 mm/mempool.c:391
 bio_alloc_bioset+0x36e/0x600 block/bio.c:486
 bio_alloc include/linux/bio.h:402 [inline]
 blkdev_issue_flush+0x20/0x1a0 block/blk-flush.c:460
 blkdev_fsync+0x8e/0xd0 fs/block_dev.c:713
 vfs_fsync_range+0x13d/0x230 fs/sync.c:202
 generic_write_sync include/linux/fs.h:2757 [inline]
 blkdev_write_iter+0x3e4/0x550 fs/block_dev.c:1936
 call_write_iter include/linux/fs.h:1919 [inline]
 do_iter_readv_writev+0x476/0x750 fs/read_write.c:740
 do_iter_write+0x191/0x670 fs/read_write.c:866
 vfs_iter_write+0x70/0xa0 fs/read_write.c:907
 iter_file_splice_write+0x762/0xc30 fs/splice.c:686
 do_splice_from fs/splice.c:764 [inline]
 direct_splice_actor+0x10f/0x170 fs/splice.c:933
 splice_direct_to_actor+0x387/0x980 fs/splice.c:888
 do_splice_direct+0x1c4/0x290 fs/splice.c:976
 do_sendfile+0x553/0x1090 fs/read_write.c:1257
 __do_sys_sendfile64 fs/read_write.c:1318 [inline]
 __se_sys_sendfile64 fs/read_write.c:1304 [inline]
 __x64_sys_sendfile64+0x1d1/0x210 fs/read_write.c:1304
 do_syscall_64+0x33/0x40 arch/x86/entry/common.c:46
 entry_SYSCALL_64_after_hwframe+0x62/0xc7
RIP: 0033:0x7fef3c2d7b19
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fef3984d188 EFLAGS: 00000246 ORIG_RAX: 0000000000000028
RAX: ffffffffffffffda RBX: 00007fef3c3eaf60 RCX: 00007fef3c2d7b19
RDX: 0000000000000000 RSI: 0000000000000004 RDI: 0000000000000006
RBP: 00007fef3984d1d0 R08: 0000000000000000 R09: 0000000000000000
R10: 000000007ffffff9 R11: 0000000000000246 R12: 0000000000000002
R13: 00007ffdf3687f4f R14: 00007fef3984d300 R15: 0000000000022000
FAULT_INJECTION: forcing a failure.
name failslab, interval 1, probability 0, space 0, times 0
CPU: 1 PID: 16848 Comm: syz-executor.3 Not tainted 5.10.199 #1
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x107/0x167 lib/dump_stack.c:118
 fail_dump lib/fault-inject.c:52 [inline]
 should_fail.cold+0x5/0xa lib/fault-inject.c:146
 should_failslab+0x5/0x20 mm/slab_common.c:1193
 slab_pre_alloc_hook mm/slab.h:515 [inline]
 slab_alloc_node mm/slub.c:2821 [inline]
 slab_alloc mm/slub.c:2904 [inline]
 kmem_cache_alloc+0x5b/0x310 mm/slub.c:2909
 mem_pool_alloc mm/kmemleak.c:423 [inline]
 create_object.isra.0+0x3a/0xa20 mm/kmemleak.c:578
 kmemleak_alloc_recursive include/linux/kmemleak.h:43 [inline]
 slab_post_alloc_hook mm/slab.h:534 [inline]
 slab_alloc_node mm/slub.c:2896 [inline]
 slab_alloc mm/slub.c:2904 [inline]
 __kmalloc+0x16e/0x390 mm/slub.c:3967
 kmalloc_array include/linux/slab.h:592 [inline]
 __blkdev_direct_IO_simple+0x222/0x930 fs/block_dev.c:256
 blkdev_direct_IO+0xb35/0x12a0 fs/block_dev.c:513
 generic_file_direct_write+0x20e/0x560 mm/filemap.c:3235
 __generic_file_write_iter+0x235/0x5d0 mm/filemap.c:3422
 blkdev_write_iter+0x298/0x550 fs/block_dev.c:1934
 call_write_iter include/linux/fs.h:1919 [inline]
 do_iter_readv_writev+0x476/0x750 fs/read_write.c:740
 do_iter_write+0x191/0x670 fs/read_write.c:866
 vfs_iter_write+0x70/0xa0 fs/read_write.c:907
 iter_file_splice_write+0x762/0xc30 fs/splice.c:686
 do_splice_from fs/splice.c:764 [inline]
 direct_splice_actor+0x10f/0x170 fs/splice.c:933
 splice_direct_to_actor+0x387/0x980 fs/splice.c:888
 do_splice_direct+0x1c4/0x290 fs/splice.c:976
 do_sendfile+0x553/0x1090 fs/read_write.c:1257
 __do_sys_sendfile64 fs/read_write.c:1318 [inline]
 __se_sys_sendfile64 fs/read_write.c:1304 [inline]
 __x64_sys_sendfile64+0x1d1/0x210 fs/read_write.c:1304
 do_syscall_64+0x33/0x40 arch/x86/entry/common.c:46
 entry_SYSCALL_64_after_hwframe+0x62/0xc7
RIP: 0033:0x7f936a2a2b19
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f9367818188 EFLAGS: 00000246 ORIG_RAX: 0000000000000028
RAX: ffffffffffffffda RBX: 00007f936a3b5f60 RCX: 00007f936a2a2b19
RDX: 0000000000000000 RSI: 0000000000000004 RDI: 0000000000000006
RBP: 00007f93678181d0 R08: 0000000000000000 R09: 0000000000000000
R10: 000000007ffffff9 R11: 0000000000000246 R12: 0000000000000002
R13: 00007ffe1c7d546f R14: 00007f9367818300 R15: 0000000000022000