audit: type=1326 audit(1701553455.174:5388): auid=0 uid=0 gid=0 ses=4 subj=system_u:system_r:kernel_t:s0 pid=12331 comm="syz-executor.0" exe="/syz-executor.0" sig=0 arch=c000003e syscall=202 compat=0 ip=0x7f71434eab19 code=0x7ffc0000
======================================================
WARNING: possible circular locking dependency detected
5.10.202 #1 Not tainted
------------------------------------------------------
syz-executor.1/12345 is trying to acquire lock:
ffff888018244ae8 ((work_completion)(&hdev->tx_work)){+.+.}-{0:0}, at: __flush_work+0xdd/0xa90 kernel/workqueue.c:3050

but task is already holding lock:
ffff888018244f40 (&hdev->req_lock){+.+.}-{3:3}, at: hci_dev_do_close+0xef/0x1240 net/bluetooth/hci_core.c:1734
audit: type=1326 audit(1701553455.174:5389): auid=0 uid=0 gid=0 ses=4 subj=system_u:system_r:kernel_t:s0 pid=12331 comm="syz-executor.0" exe="/syz-executor.0" sig=0 arch=c000003e syscall=257 compat=0 ip=0x7f714349da04 code=0x7ffc0000

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&hdev->req_lock){+.+.}-{3:3}:
       __mutex_lock_common kernel/locking/mutex.c:968 [inline]
       __mutex_lock+0x13d/0x10b0 kernel/locking/mutex.c:1109
       hci_dev_do_close+0xef/0x1240 net/bluetooth/hci_core.c:1734
       hci_rfkill_set_block+0x166/0x1a0 net/bluetooth/hci_core.c:2223
       rfkill_set_block+0x1fd/0x540 net/rfkill/core.c:341
       rfkill_fop_write+0x253/0x4b0 net/rfkill/core.c:1240
       vfs_write+0x29a/0xa70 fs/read_write.c:603
       ksys_write+0x1f6/0x260 fs/read_write.c:658
audit: type=1326 audit(1701553455.174:5390): auid=0 uid=0 gid=0 ses=4 subj=system_u:system_r:kernel_t:s0 pid=12331 comm="syz-executor.0" exe="/syz-executor.0" sig=0 arch=c000003e syscall=1 compat=0 ip=0x7f714349d5ff code=0x7ffc0000
       do_syscall_64+0x33/0x40 arch/x86/entry/common.c:46
       entry_SYSCALL_64_after_hwframe+0x62/0xc7

-> #2 (rfkill_global_mutex){+.+.}-{3:3}:
       __mutex_lock_common kernel/locking/mutex.c:968 [inline]
       __mutex_lock+0x13d/0x10b0 kernel/locking/mutex.c:1109
       rfkill_register+0x36/0xa10 net/rfkill/core.c:1016
       hci_register_dev+0x42e/0xc00 net/bluetooth/hci_core.c:3773
       __vhci_create_device+0x2c8/0x5c0 drivers/bluetooth/hci_vhci.c:129
       vhci_create_device drivers/bluetooth/hci_vhci.c:153 [inline]
       vhci_open_timeout+0x38/0x50 drivers/bluetooth/hci_vhci.c:310
       process_one_work+0x9a9/0x14b0 kernel/workqueue.c:2282
audit: type=1326 audit(1701553455.175:5391): auid=0 uid=0 gid=0 ses=4 subj=system_u:system_r:kernel_t:s0 pid=12331 comm="syz-executor.0" exe="/syz-executor.0" sig=0 arch=c000003e syscall=0 compat=0 ip=0x7f71434eab19 code=0x7ffc0000
       worker_thread+0x61d/0x1310 kernel/workqueue.c:2428
       kthread+0x38f/0x470 kernel/kthread.c:313
       ret_from_fork+0x22/0x30 arch/x86/entry/entry_64.S:299

-> #1 (&data->open_mutex){+.+.}-{3:3}:
       __mutex_lock_common kernel/locking/mutex.c:968 [inline]
       __mutex_lock+0x13d/0x10b0 kernel/locking/mutex.c:1109
       vhci_send_frame+0x63/0xa0 drivers/bluetooth/hci_vhci.c:71
       hci_send_frame+0x1b9/0x320 net/bluetooth/hci_core.c:4060
       hci_sched_acl_pkt net/bluetooth/hci_core.c:4585 [inline]
       hci_sched_acl net/bluetooth/hci_core.c:4670 [inline]
       hci_tx_work+0x10af/0x1660 net/bluetooth/hci_core.c:4741
       process_one_work+0x9a9/0x14b0 kernel/workqueue.c:2282
       worker_thread+0x61d/0x1310 kernel/workqueue.c:2428
       kthread+0x38f/0x470 kernel/kthread.c:313
       ret_from_fork+0x22/0x30 arch/x86/entry/entry_64.S:299

-> #0 ((work_completion)(&hdev->tx_work)){+.+.}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:2988 [inline]
       check_prevs_add kernel/locking/lockdep.c:3113 [inline]
       validate_chain kernel/locking/lockdep.c:3728 [inline]
       __lock_acquire+0x29e7/0x5b00 kernel/locking/lockdep.c:4954
       lock_acquire kernel/locking/lockdep.c:5565 [inline]
       lock_acquire+0x197/0x470 kernel/locking/lockdep.c:5530
       __flush_work+0x105/0xa90 kernel/workqueue.c:3053
       hci_dev_do_close+0x131/0x1240 net/bluetooth/hci_core.c:1745
       hci_rfkill_set_block+0x166/0x1a0 net/bluetooth/hci_core.c:2223
       rfkill_set_block+0x1fd/0x540 net/rfkill/core.c:341
       rfkill_fop_write+0x253/0x4b0 net/rfkill/core.c:1240
       vfs_write+0x29a/0xa70 fs/read_write.c:603
       ksys_write+0x1f6/0x260 fs/read_write.c:658
       do_syscall_64+0x33/0x40 arch/x86/entry/common.c:46
       entry_SYSCALL_64_after_hwframe+0x62/0xc7

other info that might help us debug this:

Chain exists of:
  (work_completion)(&hdev->tx_work) --> rfkill_global_mutex --> &hdev->req_lock

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&hdev->req_lock);
                               lock(rfkill_global_mutex);
                               lock(&hdev->req_lock);
  lock((work_completion)(&hdev->tx_work));

 *** DEADLOCK ***

2 locks held by syz-executor.1/12345:
audit: type=1326 audit(1701553455.345:5392): auid=0 uid=0 gid=0 ses=4 subj=system_u:system_r:kernel_t:s0 pid=12331 comm="syz-executor.0" exe="/syz-executor.0" sig=0 arch=c000003e syscall=0 compat=0 ip=0x7f714349d69c code=0x7ffc0000
 #0: ffffffff856193e8 (rfkill_global_mutex){+.+.}-{3:3}, at: rfkill_fop_write+0xff/0x4b0 net/rfkill/core.c:1232
 #1: 
audit: type=1326 audit(1701553455.351:5393): auid=0 uid=0 gid=0 ses=4 subj=system_u:system_r:kernel_t:s0 pid=12331 comm="syz-executor.0" exe="/syz-executor.0" sig=0 arch=c000003e syscall=1 compat=0 ip=0x7f714349d5ff code=0x7ffc0000
ffff888018244f40 (
audit: type=1326 audit(1701553455.351:5394): auid=0 uid=0 gid=0 ses=4 subj=system_u:system_r:kernel_t:s0 pid=12331 comm="syz-executor.0" exe="/syz-executor.0" sig=0 arch=c000003e syscall=3 compat=0 ip=0x7f714349d72b code=0x7ffc0000
&hdev->req_lock){+.+.}-{3:3}, at: hci_dev_do_close+0xef/0x1240 net/bluetooth/hci_core.c:1734

stack backtrace:
CPU: 1 PID: 12345 Comm: syz-executor.1 Not tainted 5.10.202 #1
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014
audit: type=1326 audit(1701553455.351:5395): auid=0 uid=0 gid=0 ses=4 subj=system_u:system_r:kernel_t:s0 pid=12331 comm="syz-executor.0" exe="/syz-executor.0" sig=0 arch=c000003e syscall=202 compat=0 ip=0x7f71434eab19 code=0x7ffc0000
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x107/0x167 lib/dump_stack.c:118
 check_noncircular+0x263/0x2e0 kernel/locking/lockdep.c:2123
 check_prev_add kernel/locking/lockdep.c:2988 [inline]
 check_prevs_add kernel/locking/lockdep.c:3113 [inline]
 validate_chain kernel/locking/lockdep.c:3728 [inline]
 __lock_acquire+0x29e7/0x5b00 kernel/locking/lockdep.c:4954
 lock_acquire kernel/locking/lockdep.c:5565 [inline]
 lock_acquire+0x197/0x470 kernel/locking/lockdep.c:5530
 __flush_work+0x105/0xa90 kernel/workqueue.c:3053
 hci_dev_do_close+0x131/0x1240 net/bluetooth/hci_core.c:1745
 hci_rfkill_set_block+0x166/0x1a0 net/bluetooth/hci_core.c:2223
 rfkill_set_block+0x1fd/0x540 net/rfkill/core.c:341
 rfkill_fop_write+0x253/0x4b0 net/rfkill/core.c:1240
 vfs_write+0x29a/0xa70 fs/read_write.c:603
 ksys_write+0x1f6/0x260 fs/read_write.c:658
 do_syscall_64+0x33/0x40 arch/x86/entry/common.c:46
 entry_SYSCALL_64_after_hwframe+0x62/0xc7
RIP: 0033:0x7f93ca1e3b19
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f93c7759188 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 00007f93ca2f6f60 RCX: 00007f93ca1e3b19
RDX: 0000000000000008 RSI: 00000000200000c0 RDI: 0000000000000004
RBP: 00007f93ca23df6d R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ffd7330254f R14: 00007f93c7759300 R15: 0000000000022000
FAULT_INJECTION: forcing a failure.
name failslab, interval 1, probability 0, space 0, times 0
CPU: 1 PID: 12361 Comm: syz-executor.0 Not tainted 5.10.202 #1
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x107/0x167 lib/dump_stack.c:118
 fail_dump lib/fault-inject.c:52 [inline]
 should_fail.cold+0x5/0xa lib/fault-inject.c:146
 should_failslab+0x5/0x20 mm/slab_common.c:1193
 slab_pre_alloc_hook mm/slab.h:515 [inline]
 slab_alloc_node mm/slub.c:2821 [inline]
 __kmalloc_node_track_caller+0x74/0x3b0 mm/slub.c:4496
 __kmalloc_reserve net/core/skbuff.c:142 [inline]
 __alloc_skb+0xb1/0x5b0 net/core/skbuff.c:210
 alloc_skb include/linux/skbuff.h:1102 [inline]
 nlmsg_new include/net/netlink.h:953 [inline]
 audit_buffer_alloc kernel/audit.c:1782 [inline]
 audit_log_start.part.0+0x2a3/0x730 kernel/audit.c:1900
 audit_log_start+0x5f/0x90 kernel/audit.c:1856
 audit_seccomp+0x5d/0x200 kernel/auditsc.c:2722
 seccomp_log kernel/seccomp.c:770 [inline]
 __seccomp_filter+0x62b/0x1470 kernel/seccomp.c:1012
 __secure_computing+0xac/0x290 kernel/seccomp.c:1077
 syscall_trace_enter.constprop.0+0x84/0x1e0 kernel/entry/common.c:58
 do_syscall_64+0xf/0x40 arch/x86/entry/common.c:41
 entry_SYSCALL_64_after_hwframe+0x62/0xc7
RIP: 0033:0x7f714349d69c
Code: ec 28 48 89 54 24 18 48 89 74 24 10 89 7c 24 08 e8 f9 fc ff ff 48 8b 54 24 18 48 8b 74 24 10 41 89 c0 8b 7c 24 08 31 c0 0f 05 <48> 3d 00 f0 ff ff 77 34 44 89 c7 48 89 44 24 08 e8 2f fd ff ff 48
RSP: 002b:00007f7140a60170 EFLAGS: 00000246 ORIG_RAX: 0000000000000000
RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f714349d69c
RDX: 000000000000000f RSI: 00007f7140a601e0 RDI: 0000000000000004
RBP: 00007f7140a601d0 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000002
R13: 00007ffe613ca6df R14: 00007f7140a60300 R15: 0000000000022000
FAULT_INJECTION: forcing a failure.
name failslab, interval 1, probability 0, space 0, times 0
CPU: 0 PID: 12357 Comm: syz-executor.4 Not tainted 5.10.202 #1
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x107/0x167 lib/dump_stack.c:118
 fail_dump lib/fault-inject.c:52 [inline]
 should_fail.cold+0x5/0xa lib/fault-inject.c:146
 should_failslab+0x5/0x20 mm/slab_common.c:1193
 slab_pre_alloc_hook mm/slab.h:515 [inline]
 slab_alloc_node mm/slub.c:2821 [inline]
 slab_alloc mm/slub.c:2904 [inline]
 kmem_cache_alloc+0x5b/0x310 mm/slub.c:2909
 kmem_cache_zalloc include/linux/slab.h:654 [inline]
 __alloc_file+0x21/0x320 fs/file_table.c:101
 alloc_empty_file+0x6d/0x170 fs/file_table.c:151
 alloc_file+0x5e/0x5a0 fs/file_table.c:193
 alloc_file_pseudo+0x16a/0x250 fs/file_table.c:233
 create_pipe_files+0x40e/0x8c0 fs/pipe.c:928
 __do_pipe_flags fs/pipe.c:961 [inline]
 do_pipe2+0x96/0x1b0 fs/pipe.c:1009
 __do_sys_pipe2 fs/pipe.c:1027 [inline]
 __se_sys_pipe2 fs/pipe.c:1025 [inline]
 __x64_sys_pipe2+0x50/0x80 fs/pipe.c:1025
 do_syscall_64+0x33/0x40 arch/x86/entry/common.c:46
 entry_SYSCALL_64_after_hwframe+0x62/0xc7
RIP: 0033:0x7fb873882b19
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fb870dd7188 EFLAGS: 00000246 ORIG_RAX: 0000000000000125
RAX: ffffffffffffffda RBX: 00007fb873996020 RCX: 00007fb873882b19
RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000
RBP: 00007fb870dd71d0 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000002
R13: 00007ffc0752afbf R14: 00007fb870dd7300 R15: 0000000000022000
FAULT_INJECTION: forcing a failure.
name failslab, interval 1, probability 0, space 0, times 0
CPU: 1 PID: 12378 Comm: syz-executor.0 Not tainted 5.10.202 #1
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x107/0x167 lib/dump_stack.c:118
 fail_dump lib/fault-inject.c:52 [inline]
 should_fail.cold+0x5/0xa lib/fault-inject.c:146
 should_failslab+0x5/0x20 mm/slab_common.c:1193
 slab_pre_alloc_hook mm/slab.h:515 [inline]
 slab_alloc_node mm/slub.c:2821 [inline]
 slab_alloc mm/slub.c:2904 [inline]
 kmem_cache_alloc+0x5b/0x310 mm/slub.c:2909
 mem_pool_alloc mm/kmemleak.c:423 [inline]
 create_object.isra.0+0x3a/0xa20 mm/kmemleak.c:578
 kmemleak_alloc_recursive include/linux/kmemleak.h:43 [inline]
 slab_post_alloc_hook mm/slab.h:534 [inline]
 slab_alloc_node mm/slub.c:2896 [inline]
 __kmalloc_node_track_caller+0x1a6/0x3b0 mm/slub.c:4496
 __kmalloc_reserve net/core/skbuff.c:142 [inline]
 __alloc_skb+0xb1/0x5b0 net/core/skbuff.c:210
 alloc_skb include/linux/skbuff.h:1102 [inline]
 nlmsg_new include/net/netlink.h:953 [inline]
 audit_buffer_alloc kernel/audit.c:1782 [inline]
 audit_log_start.part.0+0x2a3/0x730 kernel/audit.c:1900
 audit_log_start+0x5f/0x90 kernel/audit.c:1856
 audit_seccomp+0x5d/0x200 kernel/auditsc.c:2722
 seccomp_log kernel/seccomp.c:770 [inline]
 __seccomp_filter+0x62b/0x1470 kernel/seccomp.c:1012
 __secure_computing+0xac/0x290 kernel/seccomp.c:1077
 syscall_trace_enter.constprop.0+0x84/0x1e0 kernel/entry/common.c:58
 do_syscall_64+0xf/0x40 arch/x86/entry/common.c:41
 entry_SYSCALL_64_after_hwframe+0x62/0xc7
RIP: 0033:0x7f714349d69c
Code: ec 28 48 89 54 24 18 48 89 74 24 10 89 7c 24 08 e8 f9 fc ff ff 48 8b 54 24 18 48 8b 74 24 10 41 89 c0 8b 7c 24 08 31 c0 0f 05 <48> 3d 00 f0 ff ff 77 34 44 89 c7 48 89 44 24 08 e8 2f fd ff ff 48
RSP: 002b:00007f7140a60170 EFLAGS: 00000246 ORIG_RAX: 0000000000000000
RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f714349d69c
RDX: 000000000000000f RSI: 00007f7140a601e0 RDI: 0000000000000004
RBP: 00007f7140a601d0 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000002
R13: 00007ffe613ca6df R14: 00007f7140a60300 R15: 0000000000022000